Skip to content

Update values.yaml to adhere to kyverno pod-security-standards rules#647

Merged
inteon merged 1 commit intomasterfrom
pod_security_standards
Apr 22, 2025
Merged

Update values.yaml to adhere to kyverno pod-security-standards rules#647
inteon merged 1 commit intomasterfrom
pod_security_standards

Conversation

@inteon
Copy link
Contributor

@inteon inteon commented Apr 22, 2025

Updates values.yaml to adhere to kyverno pod-security-standards rules.

This PR also fixes bug in schema and docs (due to missing # +docs:property comments).

Fixes https://venafi.atlassian.net/browse/VC-39710

… also fixes bug in schema and docs

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@wallrj wallrj requested review from Copilot and wallrj April 22, 2025 12:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the values.yaml configuration and the corresponding documentation to ensure adherence to kyverno pod-security-standards rules and fixes an issue in the schema and docs by adding missing documentation comments.

  • Updated pod security context properties to include allowPrivilegeEscalation and seccompProfile in values.yaml.
  • Revised the documentation in README.md to accurately reflect the new security context and resource configuration settings.

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
deploy/charts/venafi-kubernetes-agent/values.yaml Added new securityContext properties and documentation comments.
deploy/charts/venafi-kubernetes-agent/README.md Updated example snippets to match the new configuration in values.yaml.
Files not reviewed (2)
  • deploy/charts/venafi-kubernetes-agent/values.schema.json: Language not supported
  • make/verify-pod-security-standards-exceptions.yaml: Language not supported

Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems to work. I ran the E2E test script:

$ ./hack/e2e/test.sh
...


{"ts":1745328714458.9692,"caller":"agent/run.go:413","msg":"Data sent successfully","v":0,"logger":"Run.gatherAndOutputData.postData"}
{
  "count": 1,
  "certificates": [
    {
      "id": "944fbf40-1f7e-11f0-b988-e7e9bc1bc9b0",
      "companyId": "9a0cab61-2b00-11ee-ba09-0733b0fe5adc",
      "managedCertificateId": "945652ef-1f7e-11f0-8224-5666cfdd2767",
      "fingerprint": "502224EFB76A2AD516AFB6D5FE2BBE3E3A7337EA",
      "certificateName": "venafi-kubernetes-agent-e2e.58dcdd7f-c5f2-4849-abc5-3f02607e7073",
      "issuerCertificateIds": [],
      "certificateStatus": "ACTIVE",
      "modificationDate": "2025-04-22T13:34:57.365+00:00",
      "validityStart": "2025-04-22T13:32:09.000+00:00",
      "validityEnd": "2026-04-22T13:32:09.000+00:00",
      "selfSigned": true,
      "signatureAlgorithm": "SHA256_WITH_RSA_ENCRYPTION",
      "signatureHashAlgorithm": "SHA256",
      "encryptionType": "RSA",
      "keyStrength": 2048,
      "subjectKeyIdentifierHash": "647307F49305AE32C5B989AA37EB0F3102F6B369",
      "authorityKeyIdentifierHash": "647307F49305AE32C5B989AA37EB0F3102F6B369",
      "serialNumber": "246EA6092FC264AE753A46ECD8FDF2979B0BCA71",
      "subjectDN": "cn=venafi-kubernetes-agent-e2e.58dcdd7f-c5f2-4849-abc5-3f02607e7073",
      "subjectCN": [
        "venafi-kubernetes-agent-e2e.58dcdd7f-c5f2-4849-abc5-3f02607e7073"
      ],
      "subjectAlternativeNamesByType": {
        "otherName": [],
        "rfc822Name": [],
        "dNSName": [],
        "x400Address": [],
        "directoryName": [],
        "ediPartyName": [],
        "uniformResourceIdentifier": [],
        "iPAddress": [],
        "registeredID": []
      },
      "issuerDN": "cn=venafi-kubernetes-agent-e2e.58dcdd7f-c5f2-4849-abc5-3f02607e7073",
      "issuerCN": [
        "venafi-kubernetes-agent-e2e.58dcdd7f-c5f2-4849-abc5-3f02607e7073"
      ],
      "ocspNoCheck": false,
      "versionType": "CURRENT",
      "totalInstanceCount": 1,
      "totalActiveInstanceCount": 0,
      "instances": [],
      "ownership": {}
    }
  ]
}

image

@inteon inteon merged commit 11a2dbd into master Apr 22, 2025
2 checks passed
@wallrj wallrj deleted the pod_security_standards branch April 22, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants