Merged
Conversation
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
requested review from
SgtCoDFish,
maelvls and
wallrj
and removed request for
maelvls
maelvls
approved these changes
Jun 10, 2025
|
|
||
| // We don't do this for the VenafiCloudVenafiConnection mode because | ||
| // the upload_path field is ignored in that mode. | ||
| log.Info("Loading upload_path from \"venafi-cloud\" configuration.") |
Member
There was a problem hiding this comment.
Why is this unconditionally logged? It used to be only logged in "key pair" mode.
Contributor
Author
There was a problem hiding this comment.
It still is only logged in "key pair" mode: https://github.com/jetstack/jetstack-secure/pull/661/files/84570e79542e103e7997c509f9d198052da5f97c#diff-4c826b1b395b31baef6313ac64f7d6e2283739d884418144b0ff908302af6eebR740
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createCredentialClient