[VC-43403] Fix cmd tests #693
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test in
cmd/
was not being run in CI so we didn't notice that it was failing.It has been failing since we merged #670, because there we added the clusteruid detection to the agent startup code, and it unconditionally attempts to connect to a Kubernetes cluster, even when the agent is being run with --input-file and --output-file.
The
--input-file
option is used for testing the pushing of data to TLSPK or Jetstack Secure, in isolation.The
--output-file
option is used for testing the collection of data, in isolation.And theoretically, a user might choose to collect data from "air-gapped" (non-Internet-connected) clusters, using
--output-file
,then use another instance of the agent to push the data to TLSPK from an Internet connected server.
I intend to move the clusteruid detection to be part of the data gathering process, in another PR: #687.
Here's the test failing, after I added the test to
make test-unit
: