Skip to content

Support supplying API key via env #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aidy merged 1 commit into from
Dec 5, 2025
Merged

Support supplying API key via env #98

aidy merged 1 commit into from
Dec 5, 2025

Conversation

@aidy
Copy link
Collaborator

@aidy aidy commented Nov 4, 2025

connects #97

@aidy aidy requested review from davidcollom and hawksight November 4, 2025 19:51
@snyk-io
Copy link

snyk-io bot commented Nov 4, 2025 •
edited
Loading

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Code Security 0 0 0 0 0 issues
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

hawksight
hawksight approved these changes Dec 5, 2025
View reviewed changes
Copy link
Member

@hawksight hawksight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible. I guess it'd be easy to do the same with TLSPC_ENDPOINT env var too.

@aidy
Copy link
Collaborator Author

aidy commented Dec 5, 2025

I guess it'd be easy to do the same with TLSPC_ENDPOINT env var too.
https://github.com/jetstack/terraform-provider-tlspc/pull/98/files#diff-58d6a027753b50994deb7e11e4a99dde423f35844986019bd9cea5e0c94aba22R80

TLSPC_ENDPOINT already works this way

@aidy aidy merged commit 3e2b64f into main Dec 5, 2025
17 checks passed
@aidy aidy deleted the env_api_key branch December 5, 2025 10:08
@aidy aidy mentioned this pull request Dec 22, 2025
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hawksight hawksight hawksight approved these changes

@davidcollom davidcollom Awaiting requested review from davidcollom

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aidy @hawksight