Simplify release name/number generation into one job

Author: davidcollom

.github/workflows/release.yaml

@@ -12,9 +12,22 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  release-name:
+    runs-on: ubuntu-latest
+    outputs:
+      name: ${{ steps.release_number.outputs.substring }}
+    steps:
+      - uses: bhowell2/[email protected]
+        id: release_number
+        with:
+          value: ${{github.ref_name}}
+          index_of_str: "release-"
+
   prepare-release:
     # Don't push back to a tag!
     if: ${{ !startsWith(github.ref, 'refs/tags/') }}
+    needs:
+      - release-name
     name: Prepare release
     runs-on: ubuntu-latest
     permissions:
@@ -31,33 +44,27 @@ jobs:
         with:
           go-version-file: go.mod
 
-      - uses: bhowell2/[email protected]
-        id: release_number
-        with:
-          value: ${{github.ref_name}}
-          index_of_str: "release-"
-
       - name: Find and Replace Helm Chart Version
         uses: jacobtomlinson/gha-find-replace@v3
         with:
           find: 'v(\d+)\.(\d+)\.(\d+)(-rc(\d)+)?'
-          replace: "${{steps.release_number.outputs.substring}}"
+          replace: "${{needs.release-name.outputs.name}}"
           include: "deploy/charts/version-checker/Chart.yaml"
           regex: true
 
       - name: Find and Replace Kubernetes Manifests
         uses: jacobtomlinson/gha-find-replace@v3
         with:
           find: 'v(\d+)\.(\d+)\.(\d+)(-rc(\d)+)?'
-          replace: "${{steps.release_number.outputs.substring}}"
+          replace: "${{needs.release-name.outputs.name}}"
           include: "deploy/yaml/deploy.yaml"
           regex: true
 
       - name: Find and Replace Makefile versions
         uses: jacobtomlinson/gha-find-replace@v3
         with:
           find: 'v(\d+)\.(\d+)\.(\d+)(-rc(\d)+)?'
-          replace: "${{steps.release_number.outputs.substring}}"
+          replace: "${{needs.release-name.outputs.name}}"
           include: "Makefile"
           regex: true
 
@@ -89,7 +96,7 @@ jobs:
           git config --local user.email "github-actions[bot]@users.noreply.github.com"
           git config --local user.name "github-actions[bot]"
           git status
-          git commit -a -m "Bump versions to ${{steps.release_number.outputs.substring}}"
+          git commit -a -m "Bump versions to ${{needs.release-name.outputs.name}}"
 
       - name: Push changes
         if: steps.filter.outputs.versions == 'true'
@@ -107,7 +114,7 @@ jobs:
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           target_branch: main
-          title: "Release ${{steps.release_number.outputs.substring}}"
+          title: "Release ${{needs.release-name.outputs.name}}"
           body: |-
             "**Automated Release Pull Request**
 
@@ -121,6 +128,8 @@ jobs:
     runs-on: ubuntu-latest
     permissions:
       id-token: write
+    needs:
+      - release-name
     steps:
       - name: Checkout code
         uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
@@ -142,6 +151,7 @@ jobs:
         uses: azure/setup-helm@v4
 
       - name: Login to Quay.io
+        if: startsWith(github.ref, 'refs/tags/')
         run: echo "${{ secrets.QUAY_ROBOT_TOKEN }}" | helm registry login quay.io -u ${{ secrets.QUAY_USERNAME }} --password-stdin
 
       - name: package helm chart
@@ -150,15 +160,15 @@ jobs:
 
       - name: Sign Helm Chart
         run: |
-          cosign sign-blob -y jetstack-charts/charts/version-checker-${{steps.release_number.outputs.substring}}.tgz \
-            --bundle jetstack-charts/charts/version-checker-${{steps.release_number.outputs.substring}}.tgz.cosign.bundle
+          cosign sign-blob -y jetstack-charts/charts/version-checker-${{needs.release-name.outputs.name}}.tgz \
+            --bundle jetstack-charts/charts/version-checker-${{needs.release-name.outputs.name}}.tgz.cosign.bundle
 
       - name: Creating PR
         uses: peter-evans/create-pull-request@v7
         with:
           token: ${{ secrets.JETSTACK_CHARTS_PAT }}
-          title: "Release version-checker ${{github.ref_name }}"
-          commit-message: "Release version-checker ${{github.ref_name }}"
+          title: "Release version-checker ${{needs.release-name.outputs.name }}"
+          commit-message: "Release version-checker ${{needs.release-name.outputs.name }}"
           branch: version-checker/${{github.ref_name}}
           path: jetstack-charts
           add-paths: |
@@ -172,12 +182,14 @@ jobs:
       - name: Push to Quay
         if: startsWith(github.ref, 'refs/tags/')
         run: |-
-          helm push jetstack-charts/charts/version-checker-${{ steps.release_number.outputs.substring }}.tgz oci://quay.io/quay.io/jetstack/version-checker/chart
+          helm push jetstack-charts/charts/version-checker-${{ needs.release-name.outputs.name }}.tgz oci://quay.io/quay.io/jetstack/version-checker/chart:${{needs.release-name.outputs.name}}
 
   docker-release:
     runs-on: ubuntu-latest
     permissions:
       id-token: write
+    needs:
+      - release-name
     steps:
       - name: Checkout code
         uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
@@ -239,6 +251,8 @@ jobs:
     permissions:
       contents: write
     runs-on: ubuntu-latest
+    needs:
+      - release-name
     steps:
       - name: Create Release / Change Logs
         uses: softprops/action-gh-release@v2