revert workflow changes

Author: David Collom

.github/workflows/build-test.yaml

@@ -9,27 +9,22 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  setup:
-    name: "Checkout and Setup"
+  lint:
+    permissions:
+      contents: read # for actions/checkout to fetch code
+      pull-requests: read # for golangci/golangci-lint-action to fetch pull requests
+      checks: write # for golangci/golangci-lint-action to annotate Pull Requests
+    name: Lint Go code
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
         uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+
       - name: Setup Golang
         uses: actions/setup-go@v5
         with:
           go-version-file: go.mod
 
-  lint:
-    needs:
-      - setup
-    permissions:
-      contents: read # for actions/checkout to fetch code
-      pull-requests: read # for golangci/golangci-lint-action to fetch pull requests
-      checks: write # for golangci/golangci-lint-action to annotate Pull Requests
-    name: Lint Go code
-    runs-on: ubuntu-latest
-    steps:
       - name: Run golangci-lint
         uses: golangci/golangci-lint-action@1481404843c368bc19ca9406f87d6e0fc97bdcfd # v7.0.0
         with:
@@ -38,23 +33,31 @@ jobs:
           only-new-issues: true
 
   govulncheck:
-    needs:
-      - setup
     runs-on: ubuntu-latest
     name: Run govulncheck
     steps:
+      # We only need to checkout as govuln does the go setup...
+      - name: Checkout code
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+
       - id: govulncheck
         uses: golang/govulncheck-action@v1
         with:
           go-version-file: go.mod
           go-package: ./...
 
   test:
-    needs:
-      - setup
     name: Run unit tests for Go packages
     runs-on: ubuntu-latest
     steps:
+      - name: Checkout code
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+
+      - name: Setup Golang
+        uses: actions/setup-go@v5
+        with:
+          go-version-file: go.mod
+
       - name: Download and required packages
         run: |
           make deps
@@ -79,7 +82,6 @@ jobs:
 
   build:
     needs:
-      - setup
       - test
       - lint
     runs-on: ubuntu-latest
@@ -91,6 +93,9 @@ jobs:
           - linux/arm64
     name: Build Images
     steps:
+      - name: Checkout code
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v3
 

pkg/controller/checker/checker_test.go

@@ -579,7 +579,7 @@ func TestIsLatestSHA(t *testing.T) {
 				SHA: "456",
 				Tag: "foo",
 				Children: []*api.ImageTag{
-					&api.ImageTag{
+					{
 						SHA: "123",
 					},
 				},
@@ -598,12 +598,8 @@ func TestIsLatestSHA(t *testing.T) {
 				SHA: "",
 				Tag: "foo",
 				Children: []*api.ImageTag{
-					&api.ImageTag{
-						SHA: "123",
-					},
-					&api.ImageTag{
-						SHA: "456",
-					},
+					{SHA: "123"},
+					{SHA: "456"},
 				},
 			},
 			expResult: &Result{
@@ -619,12 +615,8 @@ func TestIsLatestSHA(t *testing.T) {
 			searchResp: &api.ImageTag{
 				SHA: "",
 				Children: []*api.ImageTag{
-					&api.ImageTag{
-						SHA: "456",
-					},
-					&api.ImageTag{
-						SHA: "789",
-					},
+					{SHA: "456"},
+					{SHA: "789"},
 				},
 			},
 			expResult: &Result{