Skip to content

Fix Helm template indentation in env #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidcollom merged 2 commits into from
Feb 14, 2025
Merged

Fix Helm template indentation in env #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0e3162
Helm: fix indentation in Helm extra environment variables
Feb 14, 2025
afacf40
Helm: do not render Pod.spec.containers.volumeMounts if no volumes pr…
Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy/charts/version-checker/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
appVersion: "v0.8.5"
version: "v0.8.5"
version: "v0.8.6"
description: A Helm chart for version-checker
home: https://github.com/jetstack/version-checker
name: version-checker
Expand Down
6 changes: 3 additions & 3 deletions deploy/charts/version-checker/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,12 @@ spec:
{{- include "version-checker.pod.envs.ghcr" . | nindent 8 }}
{{- include "version-checker.pod.envs.quay" . | nindent 8 }}
{{- include "version-checker.pod.envs.selfhosted" . | nindent 6 }}
# Extra Envs
# Extra Envs
{{- if .Values.env }}
{{- toYaml .Values.env | nindent 8 }}
{{- toYaml .Values.env | nindent 10 }}
{{- end }}
volumeMounts:
{{- with .Values.extraVolumeMounts }}
volumeMounts:
{{- toYaml . | nindent 10 }}
{{- end }}
{{- with .Values.podSecurityContext }}
Expand Down
5 changes: 4 additions & 1 deletion deploy/charts/version-checker/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,10 @@ quay:
token:

# -- Can be used to provide custom environment variables e.g. proxy settings
env: {}
env:
[]
# - name: MY_VAR
# value: MY_VAR_VALUE

# -- ([]{name: "", host: "", username:"", password:"", token:""}]) Setup a number of SelfHosted Repositories and their credentials
selfhosted:
Expand Down
Loading