Skip to content

Report Errors up to reconcile, so that we can track better #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidcollom wants to merge 1 commit into from
Closed

Report Errors up to reconcile, so that we can track better #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/controller/pod_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,14 @@ func (r *PodReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.R
return ctrl.Result{Requeue: false}, nil
}
if err != nil {
return ctrl.Result{}, err
return ctrl.Result{RequeueAfter: (r.RequeueDuration / 2)}, err
}

// Perform the version check (your sync logic)
if err := r.sync(ctx, pod); err != nil {
log.Error(err, "Failed to process pod")
// Requeue after some time in case of failure
return ctrl.Result{RequeueAfter: (r.RequeueDuration / 2)}, nil
return ctrl.Result{RequeueAfter: (r.RequeueDuration / 2)}, err
}

// Schedule next check
Expand Down
3 changes: 1 addition & 2 deletions pkg/controller/pod_sync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,7 @@ func (c *PodReconciler) syncContainer(ctx context.Context,
err = c.checkContainer(ctx, log, pod, container, containerType, opts)
// Don't re-sync, if no version found meeting search criteria
if versionerrors.IsNoVersionFound(err) {
log.Error(err.Error())
return nil
return err
}
if err != nil {
return fmt.Errorf("failed to check container image %q: %s",
Expand Down
Loading