validate selfhosted options #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
fixes #315 |
paulwilljones
commented
Apr 17, 2025
| envPrefix, envSelfhostedPrefix, envSelfhostedHost, | ||
| )) | ||
| fs.StringVar(&o.selfhosted.Host, | ||
| fs.StringVar(&o.selfhosted.CAPath, |
Contributor
Author
There was a problem hiding this comment.
@davidcollom I think this had been incorrectly set to Host, seems like the flag wasn't going to the right field of CAPath?
Contributor
Author
VERSION_CHECKER_SELFHOSTED_USERNAME_FOO=bar ./bin/version-checker
panic: invalid self hosted configuration |
davidcollom
approved these changes
Apr 18, 2025
Contributor
davidcollom
left a comment
davidcollom
left a comment
There was a problem hiding this comment.
Thanks for this and agree, the capath option was using the wrong field 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.