Prevent resource leak in keyfunc initialization #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Micah Parks <[email protected]>
MicahParks
commented
Jun 1, 2025
| var k keyfunc.Keyfunc | ||
| var err error | ||
| if opts.JWKSURI != "" { | ||
| k, err = keyfunc.NewDefaultCtx(context.TODO(), []string{opts.JWKSURI}) |
Contributor
Author
There was a problem hiding this comment.
I used the same context as what was being replaced. The keyfunc.NewDefault function can be used instead if no context is required. The context.Background() will be used by default.
davidcollom
approved these changes
Jun 3, 2025
Contributor
davidcollom
left a comment
davidcollom
left a comment
There was a problem hiding this comment.
Amazing! Thanks for raising! <3
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
keyfunc.NewDefaultfunction will launch a new goroutine. This goroutine will periodically perform an HTTP request to refresh the remote JWK Set.The current implementation calls this function every time a JWT's expiration is checked. This will cause a compounding resource leak of goroutines periodically performing HTTP requests. This PR aims to fix that.