Skip to content

Implement conservative CSS refactoring with dual-class BEM approach f… #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pftg merged 1 commit into from
Sep 17, 2025
Merged

Implement conservative CSS refactoring with dual-class BEM approach f… #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .dev/compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,11 @@ services:
- bundle:/opt/bundle
- hugo_cache_dtest:/tmp/hugo_cache_dtest
environment:
HUGO_PUBLIC_DIR: "_dest/public-dtest"
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

🧩 Analysis chain

HUGO_PUBLIC_DIR added — align with helpers and CI

LGTM. Please confirm test/support/hugo_helpers.rb and bin/dtest prefer HUGO_PUBLIC_DIR over HUGO_DEFAULT_PATH to avoid divergence.

🏁 Script executed:

#!/bin/bash
# Verify env usage alignment
rg -n "HUGO_PUBLIC_DIR|HUGO_DEFAULT_PATH" -C2 test/support bin | sed -n '1,120p'

Length of output: 352

Switch tests/scripts to HUGO_PUBLIC_DIR

LGTM. test/support/hugo_helpers.rb still falls back to HUGO_DEFAULT_PATH — replace with ENV.fetch("HUGO_PUBLIC_DIR", "_dest/public-test") (test/support/hugo_helpers.rb:7). Verify bin/dtest also uses HUGO_PUBLIC_DIR.

🤖 Prompt for AI Agents 
In test/support/hugo_helpers.rb around line 7, replace the current fallback to
HUGO_DEFAULT_PATH with ENV.fetch("HUGO_PUBLIC_DIR", "_dest/public-test") so
tests use the same environment variable as compose; update any references in
that file to use this fetched value instead of HUGO_DEFAULT_PATH. Also inspect
bin/dtest and ensure it reads and exports/uses ENV["HUGO_PUBLIC_DIR"] (with the
same default "_dest/public-test" if needed) so the script and tests are
consistent with .dev/compose.yml.

HUGO_DEFAULT_PATH: "_dest/public-dtest"
HUGO_CACHEDIR: "/tmp/hugo_cache_dtest"
HUGO_ENABLEGITINFO: "false"
TEST_QUIET: "true"
CAPYBARA_SCREENSHOT_ON_FAILURE: "true"
PARALLEL_TEST_PROCESSORS: 4
RUBY_THREAD_VM_STACK_SIZE: 1048576
mem_limit: 2g
cpus: '4.0'
Expand Down
624 changes: 605 additions & 19 deletions CLAUDE.md
View file
Open in desktop

Large diffs are not rendered by default.

192 changes: 0 additions & 192 deletions _playground/20250914_jt_site_onboarding_report.md
View file
Open in desktop

This file was deleted.

Loading