Skip to content

refact: continue cleanups #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pftg merged 22 commits into from
Sep 26, 2025
Merged

refact: continue cleanups #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
dd161e3
Remove FL-row dual-class from before/after pseudo-elements (BEM exists)
pftg Sep 26, 2025
3a0e569
Remove FL-row dual-class from after pseudo-element (BEM exists)
pftg Sep 26, 2025
49b801b
Remove FL-col dual-class (BEM c-column exists)
pftg Sep 26, 2025
547fc47
Remove FL-photo dual-class (BEM c-photo exists)
pftg Sep 26, 2025
40f1504
Remove FL-rich-text dual-class (BEM c-rich-text exists)
pftg Sep 26, 2025
ea43e63
Add BEM equivalent for services hero section
pftg Sep 26, 2025
ce9c0eb
Add BEM equivalent for services overview section
pftg Sep 26, 2025
af6ed69
Add BEM equivalent for services clients section
pftg Sep 26, 2025
459a6c1
Add BEM equivalent for services CTA section
pftg Sep 26, 2025
717ca3c
Flocking: remove duplicate .c-button base styles
pftg Sep 26, 2025
8110fe5
Flocking: consolidate .c-button--large definitions
pftg Sep 26, 2025
292428b
Flocking: extract form field utility patterns
pftg Sep 26, 2025
5db5f4e
Flocking: extract gap spacing utility patterns
pftg Sep 26, 2025
379c5c4
Flocking: consolidate typography patterns across form components
pftg Sep 26, 2025
22f3f57
Remove unused FL-Builder animation CSS classes
pftg Sep 26, 2025
96c5d3c
Remove unused FL-Builder bg-video-fallback CSS
pftg Sep 26, 2025
59aaedb
Remove unused FL-Builder form CSS classes
pftg Sep 26, 2025
8397a2b
Remove unused FL node CSS: .fl-node-2il86phfbmex (single occurrence)
pftg Sep 26, 2025
267f963
Remove unused FL node CSS: .fl-node-73fx8mcb9lte (single occurrence)
pftg Sep 26, 2025
6373109
Remove unused FL node CSS: .fl-node-7zdx61osbq4a (single occurrence)
pftg Sep 26, 2025
aea12cb
Remove unused FL node CSS: .fl-node-2x7c5i3nmohu (single occurrence)
pftg Sep 26, 2025
6317806
wip
pftg Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions themes/beaver/assets/css/beaver-grid-layout.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
box-sizing: border-box;
}

.c-row:before, .fl-row:before,
.c-row:after, .fl-row:after,
.c-row:before,
.c-row:after,
.fl-row-content:before,
.fl-row-content:after,
.fl-col-group:before,
Expand All @@ -22,7 +22,7 @@
content: " ";
}

.c-row:after, .fl-row:after,
.c-row:after,
.fl-row-content:after,
.fl-col-group:after,
.c-col:after, .fl-col:after,
Expand Down Expand Up @@ -530,7 +530,6 @@
min-width: 1px;
}

.fl-photo,
.c-photo {
line-height: 0;
position: relative;
Expand Down
62 changes: 62 additions & 0 deletions themes/beaver/assets/css/component-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2816,3 +2816,65 @@ body:not(.single-fl-theme-layout)
font-size: 0.9rem;
color: #555;
}

/* Services Hero - Shameless Green FL-Builder Replication */
.c-services-hero.fl-row-default-height .fl-row-content-wrap {
min-height: 100vh;
display: flex;
}

/* Services Hero - Pure BEM (Final Consolidation) */
.c-services-hero .fl-row-content-wrap {
min-height: 100vh;
display: flex;
}
Comment on lines +2821 to +2830
Copy link

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two selectors have identical styles. The second selector (.c-services-hero .fl-row-content-wrap) is more general and would apply to elements matching the first selector as well. Consider removing the redundant first selector or clarify the distinction between them.

Copilot uses AI. Check for mistakes.

/* Services Overview - Shameless Green FL-Builder Replication */
.c-services-overview.fl-row-default-height .fl-row-content-wrap {
min-height: 100vh;
display: flex;
}

/* Services Overview - Pure BEM (Final Consolidation) */
.c-services-overview .fl-row-content-wrap {
min-height: 100vh;
display: flex;
}
Comment on lines +2833 to +2842
Copy link

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate CSS rules with identical styles. The more general selector (.c-services-overview .fl-row-content-wrap) makes the first one redundant. Consider consolidating these into a single rule.

Copilot uses AI. Check for mistakes.

/* Services Clients - Shameless Green FL-Builder Replication */
.c-services-clients.fl-row-default-height .fl-row-content-wrap {
min-height: 100vh;
display: flex;
}

/* Services Clients - Pure BEM (Final Consolidation) */
.c-services-clients .fl-row-content-wrap {
min-height: 100vh;
display: flex;
}
Comment on lines +2845 to +2854
Copy link

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another instance of duplicate CSS rules. The pattern repeats across services components where the more specific selector is redundant when the general one exists.

Copilot uses AI. Check for mistakes.

/* Services CTA - Shameless Green FL-Builder Replication */
.c-services-cta.fl-col-group-custom-width {
/* CTA specific styles will be added as needed */
}

/* Standalone BEM Components - Final Consolidation Phase */
/* These classes can completely replace FL-Builder dependencies */

.c-services-hero-standalone {
min-height: 100vh;
display: flex;
width: 100%;
}

.c-services-overview-standalone {
min-height: 100vh;
display: flex;
width: 100%;
}

.c-services-clients-standalone {
min-height: 100vh;
display: flex;
width: 100%;
Comment on lines +2864 to +2879
Copy link

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These three standalone component classes have identical styles (min-height: 100vh, display: flex, width: 100%). Consider creating a shared utility class like .u-full-height-flex to reduce duplication.

Suggested change
.c-services-hero-standalone {
min-height: 100vh;
display: flex;
width: 100%;
}
.c-services-overview-standalone {
min-height: 100vh;
display: flex;
width: 100%;
}
.c-services-clients-standalone {
min-height: 100vh;
display: flex;
width: 100%;
/* Utility class for full-height flex containers */
.u-full-height-flex {
min-height: 100vh;
display: flex;
width: 100%;
}
/* Standalone BEM Components use the utility class for shared styles */
.c-services-hero-standalone,
.c-services-overview-standalone,
.c-services-clients-standalone {
/* Add the utility class in markup, or use this selector for shared styles */
/* If additional component-specific styles are needed, add them below */
/* For now, all share the .u-full-height-flex styles */

Copilot uses AI. Check for mistakes.
}
10 changes: 3 additions & 7 deletions themes/beaver/assets/css/components.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,9 @@
Button Component (c-button)
======================================== */

/* Base button component */
/* Base button component - consolidated pattern */
.c-button {
border-radius: 4px;
display: inline-block;
text-decoration: none;
/* Base button styles moved to buttons-migration.css */
}

/* Button size modifiers */
Expand All @@ -22,9 +20,7 @@
padding: 9px 18px;
}

.c-button--large {
padding: 16px 32px;
}
/* .c-button--large moved to buttons-migration.css for consolidation */

/* Button state modifiers */
.c-button:hover {
Expand Down
3 changes: 1 addition & 2 deletions themes/beaver/assets/css/components/c-typography.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,8 +269,7 @@ h6.c-heading,
FL-Builder Content Integration
========================================================================== */

.c-rich-text,
.fl-rich-text {
.c-rich-text {
// Apply typography system to FL-Builder content
h1 { @extend .c-heading--xl; }
h2 { @extend .c-heading--lg; }
Expand Down
44 changes: 44 additions & 0 deletions themes/beaver/assets/css/components/css-utilities.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,50 @@
text-align: right !important;
}

/* ========================================
Form Field Utilities - Common Patterns
======================================== */

/* Consolidates padding: 0.75rem 1rem pattern found in:
* - .c-form__field, .c-form__textarea, .c-form__select
*/
.u-form-field-padding {
padding: 0.75rem 1rem !important;
}

/* Consolidates form field transition pattern (3 duplicates) */
.u-form-field-transition {
transition: border-color 0.15s ease-in-out, box-shadow 0.15s ease-in-out !important;
}

/* ========================================
Layout Utilities - Gap Spacing Patterns
======================================== */

/* Consolidates gap: 1rem pattern found in 10+ locations */
.u-gap-md {
gap: 1rem !important;
}

/* Flex + gap combination (5+ duplicates) */
.u-flex-gap {
display: flex !important;
gap: 1rem !important;
}

/* ========================================
Typography Utilities - Body Text Patterns
======================================== */

/* Consolidates font-size: 1rem + line-height: 1.5 pattern found in:
* - forms.css (8+ instances in form fields and controls)
* - Multiple form elements with consistent typography
*/
.u-text-body {
font-size: 1rem !important;
line-height: 1.5 !important;
}

/* ========================================
Display Utilities - Common Patterns
======================================== */
Expand Down
48 changes: 0 additions & 48 deletions themes/beaver/assets/css/fl-component-layout.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,16 +107,6 @@
-webkit-transform: translate(-50%, -50%);
}

.fl-bg-video-fallback {
background-position: 50% 50%;
background-repeat: no-repeat;
background-size: cover;
bottom: 0px;
left: 0px;
position: absolute;
right: 0px;
top: 0px;
}

.fl-row-bg-slideshow, .fl-row-bg-slideshow .fl-row-content {
position: relative;
Expand Down Expand Up @@ -617,39 +607,7 @@ img.mfp-img {
font-size: 30px;
}

.fl-form-field {
margin-bottom: 15px;
}

.fl-form-field input.fl-form-error {
border-color: #DD6420;
}

.fl-form-error-message {
clear: both;
color: #DD6420;
display: none;
padding-top: 8px;
font-size: 12px;
font-weight: lighter;
}

.fl-form-button-disabled {
opacity: 0.5;
}

.fl-animation {
opacity: 0;
}

.fl-builder-preview .fl-animation, .fl-builder-edit .fl-animation, .fl-animated {
opacity: 1;
}

.fl-animated {
animation-fill-mode: both;
-webkit-animation-fill-mode: both;
}

.fl-button.fl-button-icon-animation i {
width: 0 !important;
Expand Down Expand Up @@ -1056,9 +1014,6 @@ img.mfp-img {
}
}

.fl-node-7zdx61osbq4a {
width: 100%;
}

.fl-builder-content .fl-node-f29vwky6nx4s a {
color: #ffffff;
Expand Down Expand Up @@ -1257,9 +1212,6 @@ img.mfp-img {
}
}

.fl-node-2x7c5i3nmohu {
width: 26%;
}

.fl-node-0qv8y5e3of4j {
width: 27%;
Expand Down
3 changes: 1 addition & 2 deletions themes/beaver/assets/css/fl-homepage-layout.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3047,8 +3047,7 @@ fl-builder-content *, .fl-builder-content *:before, .fl-builder-content *:after
min-height: 1px;
}

.c-column,
.fl-col {
.c-column {
float: left;
min-height: 1px;
}
Expand Down
Loading