Skip to content

Conversation

@joakime
Copy link
Contributor

@joakime joakime commented Oct 31, 2025

This is a temporary change, that will likely be undone once Jan 1, 2026 hits, and we start our new EOL branch process.
For now, we need access to these branches.

@joakime joakime requested a review from a team as a code owner October 31, 2025 13:16
@eclipse-otterdog
Copy link

Thank you for raising a pull request to update the configuration of your GitHub organization.
You can manually add reviewers to this PR to eventually enable auto-merging.

The following conditions need to fulfilled for auto-merging to be available:

  • valid configuration
  • approved by a project lead
  • does not require any secrets
  • does not update settings only accessible via the GitHub Web UI
  • does not remove any resource
Otterdog commands and options

You can trigger otterdog actions by commenting on this PR:

  • /otterdog team-info checks the team / org membership for the PR author
  • /otterdog validate validates the configuration change
  • /otterdog validate info validates the configuration change, printing also validation infos
  • /otterdog check-sync checks if the base ref is in sync with live settings
  • /otterdog merge merges and applies the changes if the PR is eligible for auto-merging (only accessible for the author)
  • /otterdog done notifies the self-service bot that a required manual apply operation has been performed (only accessible for members of the admin team)
  • /otterdog apply re-apply a previously failed attempt (only accessible for members of the admin team)

@eclipse-otterdog
Copy link

The author (joakime) of this PR is associated with this organization in the role of MEMBER.

Additionally, joakime is a member of the following teams:

@eclipse-otterdog
Copy link

Please find below the validation of the requested configuration changes:

Diff for f5cb7ba
Project rt.jetty[github_id=jetty]
  there have been 22 validation infos, enable verbose output to display them.

-  remove repo_ruleset[name="read-only-branches", repository=jetty.project] {
-    allows_creations                    = false
-    allows_deletions                    = false
-    allows_force_pushes                 = false
-    allows_updates                      = false
-    bypass_actors                       = []
-    enforcement                         = "disabled"
-    exclude_refs                        = []
-    include_refs                        = [
-      "refs/heads/jetty-9.4.x"
-      "refs/heads/jetty-10.0.x"
-      "refs/heads/jetty-11.0.x"
-    ],
-    name                                = "read-only-branches"
-    required_merge_queue                = null
-    required_pull_request               = {
-      dismisses_stale_reviews             = false
-      required_approving_review_count     = 2
-      requires_code_owner_review          = false
-      requires_last_push_approval         = false
-      requires_review_thread_resolution   = false
-    }
-    required_status_checks              = {
-      do_not_enforce_on_create            = false
-      status_checks                       = [
-        "eclipse-eca-validation:eclipsefdn/eca"
-      ],
-      strict                              = false
-    }
-    requires_commit_signatures          = false
-    requires_deployments                = false
-    requires_linear_history             = false
-    target                              = "branch"
-  }
  
  Plan: 0 to add, 0 to change, 1 to delete.

},
},
orgs.newRepoRuleset('read-only-branches') {
enforcement: "disabled",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure to understand as this enforcement should be disabled see #53
especially this comment #53 (comment)
I'm a bit confused why we would need this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants