-
Notifications
You must be signed in to change notification settings - Fork 2k
Call completeStream only once on failure. #13814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: jetty-12.0.x
Are you sure you want to change the base?
Changes from 2 commits
daa9a47
83c1718
2973561
2f7aa04
bcbf2c8
42e209f
baca52e
a326415
6bea600
649e48b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1574,9 +1574,14 @@ public void succeeded() | |
| { | ||
| httpChannelState._callbackFailure = failure; | ||
| if (!stream.isCommitted()) | ||
| // We are not committed, so we can send an error response. | ||
| errorResponse = new ErrorResponse(request); | ||
| else | ||
| else if (httpChannelState._handling == null) | ||
| // We are committed, but no longer handling, so will complete here, ignoring any pending reads/writes | ||
| completeStream = true; | ||
gregw marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| else | ||
| // We are committed and still handling, so let the HandlerInvoker complete, ignoring any pending reads/writes. | ||
| httpChannelState._streamSendState = StreamSendState.LAST_COMPLETE; | ||
|
||
| } | ||
| } | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.