Skip to content

Conversation

@krancour
Copy link
Contributor

@krancour krancour commented Sep 18, 2025

I wonder if you'd consider taking this PR to upgrade to the latest version of github.com/google/go-github? 🙏

@krancour krancour requested a review from jferrl as a code owner September 18, 2025 22:37
@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.28%. Comparing base (43e37c4) to head (61271ff).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   94.28%   94.28%           
=======================================
  Files           2        2           
  Lines         140      140           
=======================================
  Hits          132      132           
  Misses          6        6           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jferrl jferrl changed the title upgrade github.com/google/go-github to v74 chore: upgrade github.com/google/go-github to v74 Sep 19, 2025
Copy link
Owner

@jferrl jferrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jferrl jferrl merged commit 46ce695 into jferrl:main Sep 19, 2025
8 checks passed
@jferrl
Copy link
Owner

jferrl commented Sep 19, 2025

@krancour just a quick note since i see that you are working on https://github.com/akuity/kargo.

https://github.com/akuity/kargo/blob/288e98bde3980625bbe6eca1c67296195dda49ce/internal/credentials/kubernetes/github/app_token_source.go#L11C1-L19C76

Regading appTokenSource implementation, maybe you could start using https://github.com/jferrl/go-githubauth/blob/main/auth.go#L70C6-L70C31 since it supports both kind of issuer (int or string). This is something that I've implemented recently.

😃

@krancour
Copy link
Contributor Author

@jferrl fantastic! Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants