Skip to content

check for the callback before trying to pop it! #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rickwalder wants to merge 2 commits into
base: main
Choose a base branch
from
Open

check for the callback before trying to pop it! #195

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0195be9
check for the callback before trying to pop it!
rickwalder Jan 19, 2026
6cde3be
actually the issue was caused by event not being in _events
rickwalder Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pyee/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,9 +259,10 @@ def g(

def _remove_listener(self: Self, event: str, f: Callable) -> None:
"""Naked unprotected removal."""
self._events[event].pop(f)
if not len(self._events[event]):
del self._events[event]
if event in self._events:
self._events[event].pop(f)
if not self._events[event]:
del self._events[event]

def remove_listener(self: Self, event: str, f: Callable) -> None:
"""Removes the function `f` from `event`."""
Expand Down