Assign filtered reads to cluster 0 when writing annotated FastQ file#18
Open
Redmar-van-den-Berg wants to merge 1 commit intojfjlaros:masterfrom
Open
Assign filtered reads to cluster 0 when writing annotated FastQ file#18Redmar-van-den-Berg wants to merge 1 commit intojfjlaros:masterfrom
Redmar-van-den-Berg wants to merge 1 commit intojfjlaros:masterfrom
Conversation
This ensures that every read from the input is written to the annotated output file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Make cluster id 0 a special case for reads that could not be clustered, for example because they contain
Ncharacters or are too short. Since 0 is reserved, regular clusters start counting from 1.Breaking Changes
The only changes for the user are that all reads from the input file will be present in the annotated output file (in the same order), and that the cluster id's now start from 1.
Fixes
This fixes an issue where the annotated FastQ output file contains fewer reads than the input file in cases where there are reads which are too short or contain
Ncharacters.