Skip to content

Add type alias rules #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
decioferreira wants to merge 4 commits into
base: unused-record-fields
Choose a base branch
from
Open

Add type alias rules #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64efe39
Add type alias simple tests and initial implementation
decioferreira Apr 13, 2023
98e594c
Moved rule into NoUnused.AliasRecordFields
decioferreira Apr 14, 2023
2c4b226
Added new test for nested record scenario
decioferreira Apr 17, 2023
a6fc116
Added new test for custom types reference
decioferreira Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Provides [`elm-review`](https://package.elm-lang.org/packages/jfmengels/elm-revi

## Provided rules

- [`NoUnused.AliasRecordFields`](https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.1.29/NoUnused-AliasRecordFields) - Reports REPLACEME.
- [🔧 `NoUnused.Variables`](https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.1.29/NoUnused-Variables/ "Provides automatic fixes") - Reports unused top-level variables and types, imports and imported variables and types inside of a module.
- [🔧 `NoUnused.CustomTypeConstructors`](https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.1.29/NoUnused-CustomTypeConstructors/ "Provides automatic fixes") - Reports unused constructors for a custom type.
- [`NoUnused.CustomTypeConstructorArgs`](https://package.elm-lang.org/packages/jfmengels/elm-review-unused/1.1.29/NoUnused-CustomTypeConstructorArgs/ "Provides automatic fixes") - Reports arguments of custom type constructors that are never used.
Expand All @@ -20,6 +21,7 @@ Provides [`elm-review`](https://package.elm-lang.org/packages/jfmengels/elm-revi
```elm
module ReviewConfig exposing (config)

import NoUnused.AliasRecordFields
import NoUnused.CustomTypeConstructorArgs
import NoUnused.CustomTypeConstructors
import NoUnused.Dependencies
Expand All @@ -35,6 +37,7 @@ config : List Rule
config =
[ NoUnused.CustomTypeConstructors.rule []
, NoUnused.RecordFields.rule
, NoUnused.AliasRecordFields.rule
, NoUnused.CustomTypeConstructorArgs.rule
, NoUnused.Dependencies.rule
, NoUnused.Exports.rule
Expand Down
1 change: 1 addition & 0 deletions elm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"license": "BSD-3-Clause",
"version": "1.1.29",
"exposed-modules": [
"NoUnused.AliasRecordFields",
"NoUnused.CustomTypeConstructorArgs",
"NoUnused.CustomTypeConstructors",
"NoUnused.Dependencies",
Expand Down
2 changes: 2 additions & 0 deletions preview/src/ReviewConfig.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ when inside the directory containing this file.

-}

import NoUnused.AliasRecordFields
import NoUnused.CustomTypeConstructorArgs
import NoUnused.CustomTypeConstructors
import NoUnused.Dependencies
Expand All @@ -26,6 +27,7 @@ config : List Rule
config =
[ NoUnused.CustomTypeConstructors.rule []
, NoUnused.RecordFields.rule
, NoUnused.AliasRecordFields.rule
, NoUnused.CustomTypeConstructorArgs.rule
, NoUnused.Dependencies.rule
, NoUnused.Exports.rule
Expand Down
Loading