Merged
Conversation
eranturgeman
added
bug
github-actions
bot
removed
the
safe to test
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
Contributor
eranturgeman
added
the
safe to test
github-actions
bot
removed
the
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to security enhancement to the OIDC mechanism, identity mappings require more strict fields that will limit the oidc mechanism to a certain flow/owner/repository etc..
Since we want the tests to work in jfrog/frogbot as well as personal forks (in order to reflect changes before merges) we cannot add those kind of fields. Therefore we added a field that allows to use the "lighter" kind of identity mappings like we had before the change. Since this affects only the OIDC test we have no security risk.
We cannot see any CI changes before we merge it, therefore the tests are still seems to be failing here, but in a fork we can see the issue is fixed: