feat: Adding OpenID Connect (OIDC) implementation for Service Connections.#520
feat: Adding OpenID Connect (OIDC) implementation for Service Connections.#520HenrikStanley wants to merge 3 commits intojfrog:devfrom
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
I have read the CLA Document and I hereby sign the CLA |
|
We are a customer of both Azure DevOps and JFrog and would appreciate if this would be merged an published! thanks for the contribution... |
|
When can this PR be merged ? We are using both AzDo and Jfrog and this feature is very much needed to avoid token management. |
|
Hey @HenrikStanley, thank you so much for this amazing PR! Apologies for the delayed response — we truly appreciate your contribution. 🙏 We’ll build on top of your PR and incorporate the latest improvements. I’ll keep you posted here as we move forward. Thanks again for this valuable contribution — really great work! |
|
Seems like the support has finally been added in PR #533 I am closing this PR :) |
npm run formatfor formatting the code before submitting the pull request.This PR builds on top of the existing work by @davidcorrigan714 done in PR #495 by adding support for OpenID Connect into the Azure DevOps extension and fixes issue #494.
As part of the PR, me and my team (@davidwinslowtech @HenrikStanley and @NimaZahedi) have implemented the following:
In regards to testing, it is not feasible for us to create tests for this feature as it relies on calling the IdTokens which can only be done from the Azure DevOps pipeline as the IdToken has to be obtained from an Azure DevOps build context as part of how the security and authentication flow works. If tests for this is required we would suggest that the JFrog maintainers creates integration tests for this in their Azure DevOps pipeline setup.
Since these tokens are only available in a built context, a known limitation is also that the Task Preview feature you get when editing tasks inside of the Azure DevOps pipeline editor, cannot authenticate to the JFrog instance from that environment and get a list of available repositories etc, as the token is only valid in the context of a pipeline run.
We have done fairly extensive manual testing of the feature.