Create application command #17

asafgabai · 2025-05-19T07:19:57Z

The pull request is targeting the main branch.
The code has been validated to compile successfully by running go vet ./....
The code has been formatted properly using go fmt ./....
All static analysis checks passed.
All tests have passed. If this feature is not already covered by the tests, new tests have been added.
All integration tests have passed locally as they cannot be automated yet.
All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Added a new command for creating a new application.

jf app create [command options] --project=<value> <application-key>

github-actions · 2025-05-19T07:34:13Z

Unit Tests Results

50 tests +26 50 ✅ +26 0s ⏱️ ±0s
22 suites + 3 0 💤 ± 0
1 files ± 0 0 ❌ ± 0

Results for commit 0b7e0c3. ± Comparison against base commit 1645bf8.

♻️ This comment has been updated with latest results.

asafgabai · 2025-05-19T08:47:07Z

.golangci.yml

  staticcheck:
    # https://staticcheck.io/docs/options#checks
    checks: [ "all","-SA1019","-SA1029" ]
  gosec:


G407 is not supported anymore so it can't be excluded. Also, exclude-test-files is not supported (and probably not wanted in the first place).

application/commands/flags.go

application/commands/application/create_app_cmd.go

SaharBracha · 2025-05-20T10:50:32Z

application/commands/application/create_app_cmd.go

+		return nil, errorutils.CheckErrorf("--%s is mandatory", commands.ProjectFlag)
+	}
+
+	businessCriticality := ctx.GetStringFlagValue(commands.BusinessCriticalityFlag)


consider extracting to util function, as it is the same exact usage for maturityLevel

application/model/create_app_request.go

github-actions · 2025-05-20T15:00:41Z

🐸 JFrog Frogbot

Create application command

402ea93

asafgabai added new feature Automatically generated release notes safe to test Approve running end-to-end tests on a pull request labels May 19, 2025

asafgabai temporarily deployed to frogbot May 19, 2025 07:20 — with GitHub Actions Inactive

Create application command

81bada5

asafgabai temporarily deployed to frogbot May 19, 2025 07:32 — with GitHub Actions Inactive

Create application command

bb83487

asafgabai temporarily deployed to frogbot May 19, 2025 07:51 — with GitHub Actions Inactive

Create application command

9a463db

asafgabai temporarily deployed to frogbot May 19, 2025 08:10 — with GitHub Actions Inactive

Create application command

9f1939d

asafgabai temporarily deployed to frogbot May 19, 2025 08:13 — with GitHub Actions Inactive

Create application command

9edf5a4

asafgabai temporarily deployed to frogbot May 19, 2025 08:18 — with GitHub Actions Inactive

Static analysis fixes

3ef91d9

asafgabai temporarily deployed to frogbot May 19, 2025 08:42 — with GitHub Actions Inactive

asafgabai marked this pull request as ready for review May 19, 2025 08:45

asafgabai commented May 19, 2025

View reviewed changes

Create application command

f2106be

asafgabai temporarily deployed to frogbot May 20, 2025 06:05 — with GitHub Actions Inactive

Create application command

d6552a1

asafgabai temporarily deployed to frogbot May 20, 2025 06:16 — with GitHub Actions Inactive

Create application command

362f730

asafgabai temporarily deployed to frogbot May 20, 2025 08:35 — with GitHub Actions Inactive

Create application command

730d870

asafgabai temporarily deployed to frogbot May 20, 2025 10:34 — with GitHub Actions Inactive

asafgabai mentioned this pull request May 20, 2025

Update application command #18

Merged

7 tasks