Skip to content

Conversation

@asafgabai
Copy link
Collaborator

@asafgabai asafgabai commented May 21, 2025

  • The pull request is targeting the main branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All integration tests have passed locally as they cannot be automated yet.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Changed mentions of Application and Application Lifecycle to AppTrust.
Changed the app command to at (still commented out).
Package renames.

@asafgabai asafgabai added improvement Automatically generated release notes safe to test Approve running end-to-end tests on a pull request labels May 21, 2025
@asafgabai asafgabai marked this pull request as ready for review May 21, 2025 13:15
@github-actions
Copy link
Contributor

Unit Tests Results

56 tests  ±0   56 ✅ ±0   0s ⏱️ ±0s
22 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 2f10d8a. ± Comparison against base commit 589111b.

This pull request removes 56 and adds 56 tests. Note that renamed tests count towards both.
github.com/jfrog/jfrog-cli-application/application/app ‑ TestGetApplicationService
github.com/jfrog/jfrog-cli-application/application/app ‑ TestGetConfig
github.com/jfrog/jfrog-cli-application/application/app ‑ TestGetSystemService
github.com/jfrog/jfrog-cli-application/application/app ‑ TestGetVersionService
github.com/jfrog/jfrog-cli-application/application/app ‑ TestNewAppContext
github.com/jfrog/jfrog-cli-application/application/commands/application ‑ TestCreateAppCommand_Error
github.com/jfrog/jfrog-cli-application/application/commands/application ‑ TestCreateAppCommand_Run
github.com/jfrog/jfrog-cli-application/application/commands/application ‑ TestCreateAppCommand_WrongNumberOfArguments
github.com/jfrog/jfrog-cli-application/application/commands/application ‑ TestDeleteAppCommand_Run
github.com/jfrog/jfrog-cli-application/application/commands/application ‑ TestDeleteAppCommand_Run_Error
…
github.com/jfrog/jfrog-cli-application/apptrust/app ‑ TestGetApplicationService
github.com/jfrog/jfrog-cli-application/apptrust/app ‑ TestGetConfig
github.com/jfrog/jfrog-cli-application/apptrust/app ‑ TestGetSystemService
github.com/jfrog/jfrog-cli-application/apptrust/app ‑ TestGetVersionService
github.com/jfrog/jfrog-cli-application/apptrust/app ‑ TestNewAppContext
github.com/jfrog/jfrog-cli-application/apptrust/commands/application ‑ TestCreateAppCommand_Error
github.com/jfrog/jfrog-cli-application/apptrust/commands/application ‑ TestCreateAppCommand_Run
github.com/jfrog/jfrog-cli-application/apptrust/commands/application ‑ TestCreateAppCommand_WrongNumberOfArguments
github.com/jfrog/jfrog-cli-application/apptrust/commands/application ‑ TestDeleteAppCommand_Run
github.com/jfrog/jfrog-cli-application/apptrust/commands/application ‑ TestDeleteAppCommand_Run_Error
…

@github-actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@asafgabai asafgabai merged commit 2571da8 into main May 25, 2025
6 checks passed
@asafgabai asafgabai deleted the APP-527-Rename-Application-to-AppTrust branch May 25, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes safe to test Approve running end-to-end tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants