Skip to content

Conversation

@asafgabai
Copy link
Collaborator

@asafgabai asafgabai commented Jun 12, 2025

  • The pull request is targeting the main branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All integration tests have passed locally as they cannot be automated yet.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

@asafgabai asafgabai added improvement Automatically generated release notes safe to test Approve running end-to-end tests on a pull request labels Jun 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2025

Unit Tests Results

78 tests  +4   78 ✅ +4   0s ⏱️ ±0s
25 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit d73730f. ± Comparison against base commit 917b4c7.

This pull request removes 4 and adds 8 tests. Note that renamed tests count towards both.
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestCommandName
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestRun
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestServerDetails
github.com/jfrog/jfrog-cli-application/apptrust/service/versions ‑ TestPromoteAppVersion/success
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestPromoteAppVersionCommand_CommandName
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestPromoteAppVersionCommand_Run
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestPromoteAppVersionCommand_Run/sync_flag_false
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestPromoteAppVersionCommand_Run/sync_flag_true
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestPromoteAppVersionCommand_Run_Error
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestPromoteAppVersionCommand_ServerDetails
github.com/jfrog/jfrog-cli-application/apptrust/service/versions ‑ TestPromoteAppVersion/success_with_sync=false
github.com/jfrog/jfrog-cli-application/apptrust/service/versions ‑ TestPromoteAppVersion/success_with_sync=true

♻️ This comment has been updated with latest results.

@asafgabai asafgabai marked this pull request as ready for review June 12, 2025 15:58
@github-actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@asafgabai asafgabai merged commit b4270b9 into main Jun 15, 2025
6 checks passed
@asafgabai asafgabai deleted the promote-version branch June 15, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes safe to test Approve running end-to-end tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants