Skip to content

Conversation

@EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Jun 18, 2025

  • The pull request is targeting the main branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All integration tests have passed locally as they cannot be automated yet.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Add Version Release Command

This PR introduces a new command version-release for releasing application versions, along with supporting utilities to enhance code reusability and maintainability.

Key Changes

  • Added new VersionRelease command with corresponding implementation and tests
  • Created new model ReleaseAppVersionRequest for the release operation
  • Added a new PropsFlag to support artifact properties for release operations
  • Updated CLI registration to include the new command

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

Unit Tests Results

85 tests  +7   85 ✅ +7   0s ⏱️ ±0s
25 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit fb90dff. ± Comparison against base commit 6d7e672.

This pull request removes 2 and adds 9 tests. Note that renamed tests count towards both.
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestPromoteAppVersionCommand_CommandName
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestPromoteAppVersionCommand_ServerDetails
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestReleaseAppVersionCommand_Run
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestReleaseAppVersionCommand_Run/sync_flag_false
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestReleaseAppVersionCommand_Run/sync_flag_true
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestReleaseAppVersionCommand_Run_Error
github.com/jfrog/jfrog-cli-application/apptrust/service/versions ‑ TestReleaseAppVersion
github.com/jfrog/jfrog-cli-application/apptrust/service/versions ‑ TestReleaseAppVersion/failure
github.com/jfrog/jfrog-cli-application/apptrust/service/versions ‑ TestReleaseAppVersion/http_client_error
github.com/jfrog/jfrog-cli-application/apptrust/service/versions ‑ TestReleaseAppVersion/success_with_sync=false
github.com/jfrog/jfrog-cli-application/apptrust/service/versions ‑ TestReleaseAppVersion/success_with_sync=true

♻️ This comment has been updated with latest results.

@EyalDelarea EyalDelarea changed the title Add Release Cmd Add Version-Release command Jun 18, 2025
@EyalDelarea EyalDelarea force-pushed the add_version_release branch from 4379059 to ba14f86 Compare June 19, 2025 09:19
@EyalDelarea EyalDelarea requested a review from asafgabai June 19, 2025 09:20
@EyalDelarea EyalDelarea marked this pull request as ready for review June 19, 2025 09:20
@EyalDelarea EyalDelarea added the safe to test Approve running end-to-end tests on a pull request label Jun 19, 2025
@github-actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@EyalDelarea EyalDelarea merged commit 2e307e8 into main Jun 22, 2025
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Approve running end-to-end tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants