Skip to content

Conversation

@asafgabai
Copy link
Collaborator

@asafgabai asafgabai commented Jun 24, 2025

  • The pull request is targeting the main branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All integration tests have passed locally as they cannot be automated yet.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Align the package-bind and package-unbind commands with the new design spec.

@asafgabai asafgabai added improvement Automatically generated release notes safe to test Approve running end-to-end tests on a pull request labels Jun 24, 2025
@github-actions
Copy link
Contributor

Unit Tests Results

118 tests   - 3   118 ✅  - 3   0s ⏱️ ±0s
 25 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit e2e4ccb. ± Comparison against base commit b15a0a0.

This pull request removes 4 and adds 1 tests. Note that renamed tests count towards both.
github.com/jfrog/jfrog-cli-application/apptrust/commands/package ‑ TestBuildPackageRequestPayload
github.com/jfrog/jfrog-cli-application/apptrust/commands/package ‑ TestBuildPackageRequestPayload/Package_request_without_versions
github.com/jfrog/jfrog-cli-application/apptrust/commands/package ‑ TestBuildPackageRequestPayload/Valid_package_request_with_multiple_versions
github.com/jfrog/jfrog-cli-application/apptrust/commands/package ‑ TestBuildPackageRequestPayload/Valid_package_request_with_single_version
github.com/jfrog/jfrog-cli-application/apptrust/service/packages ‑ TestUnbindPackage/special_characters_in_package_name

@github-actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@asafgabai asafgabai marked this pull request as ready for review June 25, 2025 06:25
Copy link
Contributor

@EyalDelarea EyalDelarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🏅

@asafgabai asafgabai merged commit d7cdd81 into main Jun 25, 2025
6 checks passed
@asafgabai asafgabai deleted the align-packages-apis branch June 25, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes safe to test Approve running end-to-end tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants