Skip to content

Conversation

@asafgabai
Copy link
Collaborator

@asafgabai asafgabai commented Jul 23, 2025

  • The pull request is targeting the main branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All integration tests have passed locally as they cannot be automated yet.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

@asafgabai asafgabai added improvement Automatically generated release notes safe to test Approve running end-to-end tests on a pull request labels Jul 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025

Unit Tests Results

150 tests  +10   150 ✅ +10   0s ⏱️ ±0s
 25 suites ± 0     0 💤 ± 0 
  1 files   ± 0     0 ❌ ± 0 

Results for commit 0199536. ± Comparison against base commit dc8e50e.

This pull request removes 1 and adds 11 tests. Note that renamed tests count towards both.
github.com/jfrog/jfrog-cli-application/apptrust/commands/application ‑ TestCreateAppCommand_Run
github.com/jfrog/jfrog-cli-application/apptrust/commands/application ‑ TestCreateAppCommand_Error_SpecAndFlags
github.com/jfrog/jfrog-cli-application/apptrust/commands/application ‑ TestCreateAppCommand_MissingProjectFlag
github.com/jfrog/jfrog-cli-application/apptrust/commands/application ‑ TestCreateAppCommand_Run_Flags
github.com/jfrog/jfrog-cli-application/apptrust/commands/application ‑ TestCreateAppCommand_Run_SpecFile
github.com/jfrog/jfrog-cli-application/apptrust/commands/application ‑ TestCreateAppCommand_Run_SpecFile/full_spec_file
github.com/jfrog/jfrog-cli-application/apptrust/commands/application ‑ TestCreateAppCommand_Run_SpecFile/invalid_spec_file
github.com/jfrog/jfrog-cli-application/apptrust/commands/application ‑ TestCreateAppCommand_Run_SpecFile/minimal_spec_file
github.com/jfrog/jfrog-cli-application/apptrust/commands/application ‑ TestCreateAppCommand_Run_SpecFile/missing_project_key
github.com/jfrog/jfrog-cli-application/apptrust/commands/application ‑ TestCreateAppCommand_Run_SpecFile/non-existent_spec_file
github.com/jfrog/jfrog-cli-application/apptrust/commands/application ‑ TestCreateAppCommand_Run_SpecFile/spec_with_application_key_that_should_be_ignored
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@asafgabai asafgabai marked this pull request as ready for review July 23, 2025 10:52
@asafgabai asafgabai merged commit b83aa2b into main Jul 27, 2025
6 checks passed
@asafgabai asafgabai deleted the create-app-with-spec-2 branch July 27, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes safe to test Approve running end-to-end tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants