Skip to content

Conversation

@asafgabai
Copy link
Collaborator

@asafgabai asafgabai commented Jul 27, 2025

  • The pull request is targeting the main branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All integration tests have passed locally as they cannot be automated yet.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

The biggest change was on the version-create command that was updated to match the new structure of the release-bundle-create command.

@asafgabai asafgabai added improvement Automatically generated release notes safe to test Approve running end-to-end tests on a pull request labels Jul 27, 2025
@github-actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@github-actions
Copy link
Contributor

Unit Tests Results

172 tests  +22   172 ✅ +22   0s ⏱️ ±0s
 25 suites ± 0     0 💤 ± 0 
  1 files   ± 0     0 ❌ ± 0 

Results for commit 938e748. ± Comparison against base commit b83aa2b.

This pull request removes 8 and adds 30 tests. Note that renamed tests count towards both.
github.com/jfrog/jfrog-cli-application/apptrust/commands/utils ‑ TestParsePackagesFlag
github.com/jfrog/jfrog-cli-application/apptrust/commands/utils ‑ TestParsePackagesFlag/empty_string
github.com/jfrog/jfrog-cli-application/apptrust/commands/utils ‑ TestParsePackagesFlag/invalid_format
github.com/jfrog/jfrog-cli-application/apptrust/commands/utils ‑ TestParsePackagesFlag/missing_name
github.com/jfrog/jfrog-cli-application/apptrust/commands/utils ‑ TestParsePackagesFlag/missing_version
github.com/jfrog/jfrog-cli-application/apptrust/commands/utils ‑ TestParsePackagesFlag/multiple_packages
github.com/jfrog/jfrog-cli-application/apptrust/commands/utils ‑ TestParsePackagesFlag/single_package
github.com/jfrog/jfrog-cli-application/apptrust/commands/utils ‑ TestParsePackagesFlag/spaces
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestParseBuilds/empty_string
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestParseBuilds/invalid_format
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestParseBuilds/invalid_include_deps_value
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestParseBuilds/missing_id_field
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestParseBuilds/missing_name_field
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestParseBuilds/multiple_builds
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestParseReleaseBundles/empty_string
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestParseReleaseBundles/invalid_format
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestParseReleaseBundles/missing_name_field
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestParseReleaseBundles/missing_version_field
…

@asafgabai asafgabai marked this pull request as ready for review July 27, 2025 11:01
@asafgabai asafgabai merged commit b669f49 into main Jul 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes safe to test Approve running end-to-end tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants