Skip to content

Conversation

@EyalDelarea
Copy link
Contributor

  • The pull request is targeting the main branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All integration tests have passed locally as they cannot be automated yet.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2025

Unit Tests Results

182 tests  +4   182 ✅ +4   0s ⏱️ ±0s
 25 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 5cda814. ± Comparison against base commit 9765b4f.

This pull request removes 3 and adds 7 tests. Note that renamed tests count towards both.
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestRollbackAppVersionCommand_Run_Error
github.com/jfrog/jfrog-cli-application/apptrust/service/versions ‑ TestRollbackAppVersion/successful_rollback_with_200
github.com/jfrog/jfrog-cli-application/apptrust/service/versions ‑ TestRollbackAppVersion/successful_rollback_with_204
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestRollbackAppVersionCommand_Run/failed_rollback
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestRollbackAppVersionCommand_Run/successful_rollback_with_sync=false
github.com/jfrog/jfrog-cli-application/apptrust/commands/version ‑ TestRollbackAppVersionCommand_Run/successful_rollback_with_sync=true
github.com/jfrog/jfrog-cli-application/apptrust/service/versions ‑ TestRollbackAppVersion/failed_rollback_-_sync=false_but_got_200
github.com/jfrog/jfrog-cli-application/apptrust/service/versions ‑ TestRollbackAppVersion/failed_rollback_-_sync=true_but_got_202
github.com/jfrog/jfrog-cli-application/apptrust/service/versions ‑ TestRollbackAppVersion/successful_rollback_with_sync=false
github.com/jfrog/jfrog-cli-application/apptrust/service/versions ‑ TestRollbackAppVersion/successful_rollback_with_sync=true

♻️ This comment has been updated with latest results.

@EyalDelarea EyalDelarea changed the title Remove Async query param Remove Async query param & Fix rollback operation Aug 26, 2025
@github-actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@EyalDelarea EyalDelarea merged commit 1ab9a89 into main Aug 27, 2025
6 checks passed
@asafgabai asafgabai deleted the APP-908-Async-Remove branch October 8, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants