Skip to content

Consistent logs in CRUD operations #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asafgabai merged 1 commit into from
Sep 25, 2025
Merged

Consistent logs in CRUD operations #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions apptrust/commands/version/update_app_version_cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ type updateAppVersionCommand struct {
}

func (uv *updateAppVersionCommand) Run() error {
log.Info("Updating application version:", uv.applicationKey, "version:", uv.version)

ctx, err := service.NewContext(*uv.serverDetails)
if err != nil {
log.Error("Failed to create service context:", err)
Expand All @@ -41,7 +39,6 @@ func (uv *updateAppVersionCommand) Run() error {
return err
}

log.Info("Successfully updated application version:", uv.applicationKey, "version:", uv.version)
return nil
}

Expand Down
4 changes: 3 additions & 1 deletion apptrust/service/applications/application_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ func (as *applicationService) CreateApplication(ctx service.Context, requestBody
response.StatusCode, responseBody)
}

log.Info(fmt.Sprintf("Application \"%s\" created successfully.", requestBody.ApplicationKey))
log.Output(string(responseBody))
return nil
}
Expand All @@ -52,6 +53,7 @@ func (as *applicationService) UpdateApplication(ctx service.Context, requestBody
response.StatusCode, responseBody)
}

log.Info(fmt.Sprintf("Application \"%s\" updated successfully.", requestBody.ApplicationKey))
log.Output(string(responseBody))
return nil
}
Expand All @@ -68,6 +70,6 @@ func (as *applicationService) DeleteApplication(ctx service.Context, application
response.StatusCode, responseBody)
}

log.Output("Application deleted successfully")
log.Info(fmt.Sprintf("Application \"%s\" deleted successfully.", applicationKey))
return nil
}
3 changes: 2 additions & 1 deletion apptrust/service/packages/package_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ func (ps *packageService) BindPackage(ctx service.Context, applicationKey string
response.StatusCode, responseBody)
}

log.Info("Package bound successfully.")
log.Output(string(responseBody))
return nil
}
Expand All @@ -51,6 +52,6 @@ func (ps *packageService) UnbindPackage(ctx service.Context, applicationKey, pkg
response.StatusCode, responseBody)
}

log.Output("Package unbound successfully")
log.Info("Package unbound successfully.")
return nil
}
3 changes: 3 additions & 0 deletions apptrust/service/versions/version_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ func (vs *versionService) CreateAppVersion(ctx service.Context, request *model.C
response.StatusCode, responseBody)
}

log.Info("Application version created successfully.")
log.Output(string(responseBody))
return nil
}
Expand Down Expand Up @@ -110,6 +111,7 @@ func (vs *versionService) DeleteAppVersion(ctx service.Context, applicationKey,
response.StatusCode, responseBody)
}

log.Info("Application version deleted successfully.")
return nil
}

Expand All @@ -125,5 +127,6 @@ func (vs *versionService) UpdateAppVersion(ctx service.Context, applicationKey s
response.StatusCode, responseBody)
}

log.Info("Application version updated successfully.")
return nil
}