Skip to content

Make the delete app version request synchronous #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asafgabai merged 2 commits into from
Sep 29, 2025
Merged

Make the delete app version request synchronous #44

asafgabai merged 2 commits into from
Sep 29, 2025

Conversation

@asafgabai
Copy link
Collaborator

@asafgabai asafgabai commented Sep 28, 2025 •
edited
Loading

  • The pull request is targeting the main branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All integration tests have passed locally as they cannot be automated yet.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

@asafgabai asafgabai added bug Something isn't working safe to test Approve running end-to-end tests on a pull request labels Sep 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2025

Unit Tests Results

182 tests  ±0   182 ✅ ±0   0s ⏱️ ±0s
 25 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 7aebee4. ± Comparison against base commit 548777a.

@asafgabai asafgabai marked this pull request as ready for review September 28, 2025 16:07
EyalDelarea
EyalDelarea approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@EyalDelarea EyalDelarea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just let's make sure we know how to handle nil map 👍

@asafgabai asafgabai merged commit 9ab41f8 into main Sep 29, 2025
6 checks passed
@asafgabai asafgabai deleted the fix-version-async-operations branch October 8, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@EyalDelarea EyalDelarea EyalDelarea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working safe to test Approve running end-to-end tests on a pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asafgabai @EyalDelarea