Skip to content

Conversation

@agrasth
Copy link
Collaborator

@agrasth agrasth commented Jul 24, 2025

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • Appropriate label is added to auto generate release notes.
  • I used gofmt for formatting the code before submitting the pull request.
  • PR description is clear and concise, and it includes the proposed solution/fix.

Add Repository Type Validation for IDE Integrations (VSCode & JetBrains)

Overview

This PR enhances the IDE integration commands (vscode-config and jetbrains-config) by adding validation to ensure that the specified Artifactory repository is not only present, but also of the correct type (vscode or jetbrains). This prevents misconfiguration and provides clearer error messages to users.

Changes

  • VSCode & JetBrains Commands:
    • After checking repository existence, the commands now validate that the repository's packageType matches the expected type.
    • If the type does not match, a clear error is returned to the user.
  • Dependency:
    • Relies on a new utility function (ValidateRepoType) added to jfrog-cli-core.

Related

@agrasth agrasth requested review from bhanurp and itsmeleela July 24, 2025 07:33
@agrasth agrasth added the improvement Automatically generated release notes label Jul 24, 2025
@agrasth agrasth added ignore for release Automatically generated release notes and removed improvement Automatically generated release notes labels Jul 25, 2025
@agrasth agrasth merged commit ee0bb1c into jfrog:main Jul 27, 2025
10 of 11 checks passed
naveenku-jfrog pushed a commit to naveenku-jfrog/jfrog-cli-artifactory that referenced this pull request Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants