Add stages to release bundle evidence create#120
Merged
dortam888 merged 2 commits intojfrog:mainfrom Aug 4, 2025
Merged
Conversation
dortam888
force-pushed
the
add_stages_to_release_bundle_create
branch
from
d321a8d to
3b519e9
Compare
dortam888
force-pushed
the
add_stages_to_release_bundle_create
branch
from
3b519e9 to
cc2de3b
Compare
selalererjfrog
approved these changes
Aug 4, 2025
mnsboev
approved these changes
Aug 4, 2025
evidence/create/create_base.go
Outdated
| } | ||
|
|
||
| const EvdDefaultUser = "JFrog CLI" | ||
| const EvdStagesSupportedVersion = "7.141.0" |
Collaborator
There was a problem hiding this comment.
I didn't find where it's used. Is it needed?
Contributor
Author
There was a problem hiding this comment.
Good point. Removing it :)
| return fetchCurrentStage(promotionDetails) | ||
| } | ||
|
|
||
| func initReleasebundlePromotionDetails(releaseBundle, releaseBundleVersion, project string) (lifecycleServices.ReleaseBundleDetails, lifecycleServices.GetPromotionsOptionalQueryParams) { |
Collaborator
There was a problem hiding this comment.
The word 'Bundle' should start with an uppercase letter.
| return rbDetails, queryParams | ||
| } | ||
|
|
||
| func fetchCurrentStage(promotionDetails lifecycleServices.RbPromotionsResponse) string { |
Collaborator
There was a problem hiding this comment.
May be its better to rename this function to selectCurrentStage or selectLatestStage
Contributor
Author
There was a problem hiding this comment.
Change to getReleaseBundleCurrentPromotionStage believe its better than select
naveenku-jfrog
pushed a commit
to naveenku-jfrog/jfrog-cli-artifactory
that referenced
this pull request
Aug 13, 2025
When creating evidence on a release bundle automatically adding the promotion stage (environment) into the statement and reflect in the data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Stages in release bundle evidence creation