-
Notifications
You must be signed in to change notification settings - Fork 35
Migrate life cycle commands #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -0,0 +1,201 @@ | |||
| package flagkit | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is only used by distribution / lifecycle commands, I suggest placing it under a non common package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, please remove all unused flags from jfrog-cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is only used distribution, lifecycle since we have moved only those 2 categories for now, all command flags including artifactory or any other types if moved in future can be placed here hence the common package.
Removed unused flags from jfrg-cli
jfrog-clitojfrog-cli-artifactory.Depends On
jfrog/jfrog-cli-core#1351