Skip to content

Conversation

@bhanurp
Copy link
Collaborator

@bhanurp bhanurp commented Feb 18, 2025

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

  • Migrated all lifecycle commands from jfrog-cli to jfrog-cli-artifactory.

Depends On

jfrog/jfrog-cli-core#1351

@bhanurp bhanurp added the improvement Automatically generated release notes label Feb 18, 2025
@bhanurp bhanurp added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Feb 18, 2025
@bhanurp bhanurp marked this pull request as ready for review February 18, 2025 12:02
@@ -0,0 +1,201 @@
package flagkit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is only used by distribution / lifecycle commands, I suggest placing it under a non common package.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, please remove all unused flags from jfrog-cli

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is only used distribution, lifecycle since we have moved only those 2 categories for now, all command flags including artifactory or any other types if moved in future can be placed here hence the common package.

Removed unused flags from jfrg-cli

@bhanurp bhanurp requested a review from RobiNino March 17, 2025 02:02
@bhanurp bhanurp requested a review from RobiNino March 20, 2025 08:49
@bhanurp bhanurp added ignore for release Automatically generated release notes and removed improvement Automatically generated release notes labels Mar 24, 2025
@bhanurp bhanurp merged commit 3078dc5 into jfrog:main Mar 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants