Skip to content

Conversation

@fluxxBot
Copy link
Collaborator

@fluxxBot fluxxBot commented Apr 13, 2025

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the main branch.
  • I used gofmt for formatting the code before submitting the pull request.

depends on:

  1. cli-core - Added config arg extractor and search result to build info converter for npm jfrog-cli-core#1374
  2. cli - Support npm operations using native npm client with .npmrc via --run-native flag jfrog-cli#2952

Copy link
Collaborator

@bhanurp bhanurp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file names shouldn't be in camel case can you make it all lower case.
also consider changing files names to below to make it clear what each file holds

  • rtPublishHandler.go --> artifactoryupload.go
  • publishHandler.go --> publishstrategy.go
  • npmPublishHandler.go --> npmpublish.go

@fluxxBot fluxxBot force-pushed the npmPublishNew branch 2 times, most recently from daeb73a to e5b1256 Compare May 7, 2025 21:13
@fluxxBot fluxxBot changed the title New npm publish impl Added new npm publish and install implementation May 8, 2025
@fluxxBot fluxxBot force-pushed the npmPublishNew branch 2 times, most recently from f83a250 to d65da04 Compare May 13, 2025 10:37
@fluxxBot fluxxBot requested a review from bhanurp May 13, 2025 10:48
@fluxxBot fluxxBot merged commit 2ad0e40 into jfrog:main May 14, 2025
9 checks passed
@fluxxBot fluxxBot added the ignore for release Automatically generated release notes label May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes new feature Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants