Skip to content

Catch errors from test cli gorutines through channel #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sverdlov93 merged 2 commits into from
Jan 1, 2025
Merged

Catch errors from test cli gorutines through channel #1324

sverdlov93 merged 2 commits into from
Jan 1, 2025

Conversation

@attiasas
Copy link
Collaborator

@attiasas attiasas commented Dec 31, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Add option to run test CLI with command that return error as well

@attiasas attiasas added the ignore for release Automatically generated release notes label Dec 31, 2024
sverdlov93
sverdlov93 reviewed Dec 31, 2024
View reviewed changes
sverdlov93
sverdlov93 reviewed Dec 31, 2024
View reviewed changes
@attiasas attiasas mentioned this pull request Dec 31, 2024
Merged
7 tasks
@attiasas attiasas requested a review from sverdlov93 January 1, 2025 08:06
@sverdlov93 sverdlov93 merged commit b26e9a6 into jfrog:dev Jan 1, 2025
6 of 7 checks passed
@sverdlov93 sverdlov93 changed the title Test Cli outputs of cmd with errors Catch errors from test cli gorutines through channel Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sverdlov93 sverdlov93 sverdlov93 approved these changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

@yahavi yahavi Awaiting requested review from yahavi

@EyalDelarea EyalDelarea Awaiting requested review from EyalDelarea

Assignees

No one assigned

Labels

ignore for release Automatically generated release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@attiasas @sverdlov93