Migrate artifactory commands to jfrog-cli-artifactory#1334
Merged
Migrate artifactory commands to jfrog-cli-artifactory#1334
Conversation
518b607 to
2c41a1f
Compare
4 tasks
RobiNino
requested changes
Jan 23, 2025
Contributor
There was a problem hiding this comment.
Nice work!
Leaving most of my review as a comment since it involves unmodified files.
- artifactory/commands/gradle - should be deleted.
- artifactory/commands/testdata - should be deleted.
- Transfer command - I think those should move too, because they belong in the Artifactory repo too, even if they will fall under another team's management. This will also help avoiding the cyclic import which is problematic. Should be moved with the relevant utils in artifactory/commands/utils (precheck, and the transfer named ones)
- The tests directory that was migrated should also be deleted. Then, we can also delete the GitHub workflow if it is redundant.
Contributor
Author
artifactory/commands/gradle - deleted |
Contributor
|
It provides as a wrapping to all unit tests, so we can set a temporary jfrog home directory and set a logger. Let's currently leave this file as long as there are unit tests in this repository. |
RobiNino
approved these changes
Jan 23, 2025
Contributor
RobiNino
left a comment
There was a problem hiding this comment.
small comment, otherwise LGTM!
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request depends on the following PR: