Closed
Conversation
Contributor
RobiNino
commented
Jan 21, 2025
RobiNino
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- All static analysis checks passed.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
RobiNino
force-pushed
the
generic-git-log
branch
from
282e93d to
91541a8
Compare
EyalDelarea
approved these changes
Jan 28, 2025
Contributor
EyalDelarea
left a comment
EyalDelarea
left a comment
There was a problem hiding this comment.
LGTM
Just see my comment :)
| log.Info("Collecting build issues from VCS...") | ||
|
|
||
| // Check that git exists in path. | ||
| _, err := exec.LookPath("git") |
Contributor
There was a problem hiding this comment.
I know we call this function after .git lookup has occurred, but is there any case where someone might call it without initializing it first?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.