Support multiple image tags in build-docker-create using image-file #1373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
agrasth
commented
Apr 9, 2025
agrasth
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- All static analysis checks passed.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
bhanurp
reviewed
Apr 10, 2025
| return "http://" + endpoint | ||
| } | ||
|
|
||
| func (i *Image) SetName(name string) { |
Contributor
There was a problem hiding this comment.
This is not required if we can use NewImage() for every new tag
bhanurp
requested changes
Apr 10, 2025
Contributor
bhanurp
left a comment
bhanurp
left a comment
There was a problem hiding this comment.
Try if we can avoid this new setter
Contributor
Author
|
Implemented this without this setter SetName |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.