Include default true bool flags in CLI flag mapping#1376
Merged
EyalDelarea merged 3 commits intojfrog:devfrom Apr 16, 2025
Merged
Include default true bool flags in CLI flag mapping#1376EyalDelarea merged 3 commits intojfrog:devfrom
EyalDelarea merged 3 commits intojfrog:devfrom
Conversation
4 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🔧 Summary
This PR updates the handling of boolean flags (
BoolFlag) in thefillFlagMapsfunction.✅ Behavior Change
Previously,
BoolFlags were only added to the internal context (c.boolFlags) if they were explicitly set by the user:This caused flags with a default value of
trueto be skipped unless manually provided.The updated logic:
Now, a boolean flag is included if:
baseContext.IsSet(...))true(e.g., defaulttrue)This ensures all effective boolean flags are passed to plugin commands.
🛠 Fixes
This change resolves issues that broke certain CLI-Security plugin commands that rely on
BoolFlags withDefaultValue = true.