Feature/ide setup clean #1413
Closed
Feature/ide setup clean #1413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add jfrog-cli-core/general/ide/vscode package with VSCode configuration logic - Add jfrog-cli-core/general/ide/jetbrains package with JetBrains configuration logic - Add jfrog-cli-core/general/ide/utils package with shared IDE utilities - Implement cross-platform IDE detection and configuration - Add backup mechanisms for configuration files - Include SIP detection for macOS security requirements - Support for multiple IDE versions and installations Core implementation provides: - VSCode product.json modification for extension marketplace - JetBrains idea.properties configuration for plugin repository - Automatic IDE installation detection - Configuration backup and restore capabilities - Cross-platform file permission handling Part of SwampUp ticket implementation for IDE automated setup.
- Uncommented repository validation call in vscode.go - Validation now properly checks repository accessibility before making changes - Provides better error messages for repository configuration issues - Ensures safe configuration process with early validation
…p management - Add better System Integrity Protection (SIP) detection and guidance for macOS - Implement structured backup directory in ~/.jfrog/backup/ide/vscode/ - Enhance permission error handling with specific guidance - Add proper imports for core utilities and file operations - Improve user experience with detailed setup instructions and fallback options
- Add proactive permission checking for VSCode product.json editing - Provide clear SIP protection error messages and manual setup instructions - Improve JetBrains setup log message formatting for better readability - Add comprehensive IDE setup documentation This enables VSCode and JetBrains IDE configuration to work properly on macOS systems with System Integrity Protection (SIP) enabled.
- Remove vscode.go.backup file (should not be in repository) - Remove .gradle/ directories with build cache and metadata files - Remove Gradle execution history, file hashes, and build cleanup artifacts These files are generated during development/build and should not be committed.
…stants - Replace 404 with http.StatusNotFound - Replace 401 with http.StatusUnauthorized - Replace 403 with http.StatusForbidden Fixes usestdlibvars linting issues in IDE setup code.
agrasth
force-pushed
the
feature/ide-setup-clean
branch
from
3c11717 to
6273725
Compare
…ning 401 magic number - Remove deprecated io/ioutil imports (SA1019 warning) - Replace ioutil.ReadFile with os.ReadFile - Replace ioutil.WriteFile with os.WriteFile - Replace ioutil.ReadDir with os.ReadDir - Replace remaining 401 magic number with http.StatusUnauthorized Fixes staticcheck SA1019 and usestdlibvars linting issues in IDE setup code.
- Replace magic number 200 with http.StatusOK in vscode.go - Replace unnecessary fmt.Sprintf calls with simpler string concatenation - Fixes gosimple S1039 and usestdlibvars linting warnings
- Fix dupBranchBody by extracting common error handling logic in modifyProductJson - Replace unnecessary fmt.Sprintf calls with simple string concatenation - Fixes gocritic dupBranchBody and gosimple S1039 warnings
agrasth
force-pushed
the
feature/ide-setup-clean
branch
from
ee4f820 to
9552523
Compare
- Extract common command execution logic to eliminate duplicate branches - Both Windows and non-Windows branches now only differ in executable name - Fixes gocritic dupBranchBody warning in downloadAndInstallExtension function
agrasth
force-pushed
the
feature/ide-setup-clean
branch
from
9552523 to
f9946b3
Compare
- Update buildRepositoryURL to include /api/jetbrainsplugins/ path
- Change from: /artifactory/{repo}
- Change to: /artifactory/api/jetbrainsplugins/{repo}
- Applies to all operating systems (Windows, macOS, Linux)
- Manual setup instructions automatically reflect correct format
Contributor
Author
|
These changes are not needed anymore, as we have migrated the logic to jfrog-cli-artifactory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Improve IDE setup with SIP-aware permission handling
Summary
Enhances VSCode and JetBrains IDE setup commands to work properly on macOS systems with System Integrity Protection (SIP) enabled.
Key Changes
product.jsoneditingProblem Solved
Previously, IDE setup failed on SIP-enabled macOS without clear guidance, requiring users to disable SIP or manually configure repositories.
Impact