Skip to content

Feature/wks 1322 add versioning #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehl-jf merged 1 commit into from
Apr 30, 2025
Merged

Feature/wks 1322 add versioning #33

ehl-jf merged 1 commit into from
Apr 30, 2025

Conversation

@BlasttS
Copy link
Contributor

@BlasttS BlasttS commented Apr 22, 2025 •
edited
Loading

  • The pull request is targeting the main branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All integration tests have passed locally as they cannot be automated yet.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2025 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

ehl-jf
ehl-jf reviewed Apr 22, 2025
View reviewed changes
commands/common/test_worker_server.go Outdated

type BodyValidator func(t require.TestingT, content []byte)

type workerSent struct {
Copy link
Collaborator

@ehl-jf ehl-jf Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a more precise name, if is related to any specific endpoint, maybe workerDeployExpectedPayload or something like this ?

Copy link
Contributor Author

@BlasttS BlasttS Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to workerDeployPayload but still feels weird

@BlasttS BlasttS force-pushed the feature/WKS-1322-add-versioning branch from 72e1ffd to 0aa9134 Compare April 22, 2025 14:14
@BlasttS
Copy link
Contributor Author

BlasttS commented Apr 22, 2025

I have read the CLA Document and I hereby sign the CLA

@BlasttS
WKS-1322 - Add version flags + usage of version 2 of API for the depl…
5036600 
…oy command

Add check from server options to validate version length. Usage of V2 in test for create/update endpoints. Add test for options endpoint
@BlasttS BlasttS force-pushed the feature/WKS-1322-add-versioning branch from 0aa9134 to 5036600 Compare April 22, 2025 14:43
@ehl-jf ehl-jf merged commit bb11799 into jfrog:main Apr 30, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehl-jf ehl-jf ehl-jf left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BlasttS @ehl-jf