Skip to content

Conversation

@hadarshjfrog
Copy link
Contributor

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

As part of internal services migration of XSC into Xray - the field fail_build wasn't returning in the response from Xray - and didn't fail the run - even if it did create a violation according to the defined policies.

The fix itself happened on Xray v3.111 - and we wanted to add a test for audit to run against it as well in JFrog-CLI

@hadarshjfrog hadarshjfrog added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Dec 19, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 19, 2024
@attiasas
Copy link
Contributor

option avaliable, was introduced in diff PR, also we have a test that checks fail build that will run on 3.111 TestAuditJasViolationsProjectKeySimpleJson

@attiasas attiasas closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants