Skip to content

Conversation

@barv-jfrog
Copy link
Contributor

@barv-jfrog barv-jfrog commented Dec 31, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Improve fix dependencies function on swift


Depends on
#231

@barv-jfrog barv-jfrog changed the base branch from main to dev December 31, 2024 15:06
@barv-jfrog barv-jfrog changed the title swift/cocoapods improvement to fix tech swiftimprovement to fix tech Jan 5, 2025
@barv-jfrog barv-jfrog changed the title swiftimprovement to fix tech swift improvement to fix tech Jan 5, 2025
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Jan 5, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 5, 2025
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Jan 5, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 5, 2025
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Jan 5, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 5, 2025
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Jan 5, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 5, 2025
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Jan 5, 2025
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Jan 5, 2025
@barv-jfrog barv-jfrog requested a review from attiasas January 5, 2025 15:48
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 5, 2025
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Jan 6, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 6, 2025
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Jan 7, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 7, 2025
@attiasas attiasas added the ignore for release Automatically generated release notes label Jan 13, 2025
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, please take a look at my comments

@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Jan 13, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 13, 2025
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Jan 13, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 13, 2025
@github-actions
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/commands/audit/sca/swift 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/commands/audit/sca/swift/swift.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/jfrog/jfrog-cli-security/commands/audit/sca/swift/swift_test.go

@github-actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@attiasas attiasas merged commit 2d59df9 into jfrog:dev Jan 15, 2025
69 of 103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants