Conversation
eranturgeman
added
safe to test
attiasas
added
ignore for release
attiasas
approved these changes
Oct 12, 2025
Collaborator
attiasas
left a comment
attiasas
left a comment
There was a problem hiding this comment.
LGTM (as long as tests are passing).
This should not affect the users, it is just a refactor of some code, so I switched the label.
…o fix-get-severity-details-applicability-status-switch
eranturgeman
added
safe to test
…ails-applicability-status-switch
attiasas
added
safe to test
github-actions
bot
removed
the
safe to test
attiasas
added
the
safe to test
github-actions
bot
removed
the
safe to test
basel1322
pushed a commit
to basel1322/jfrog-cli-security
that referenced
this pull request
Dec 8, 2025
…rog#587) Co-authored-by: attiasas <assafattias93@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....This PR corrects a conflicting logic regarding severity details:
so far, if we got a 'notScanned' status we would switch it to 'applicable' since we had no support in the notScanned status, and we had an overlapping logic (to which the code could not reach) where we throw an error.
This duplicated and incorrect logic was switched to enable the notScanned status in a valid flow.