Skip to content

Tests - Fix DotNet installing on Ubuntu #2808

Merged
EyalDelarea merged 29 commits intojfrog:devfrom
EyalDelarea:fix_nuget_tests_workflow
Dec 30, 2024
Merged

Tests - Fix DotNet installing on Ubuntu #2808
EyalDelarea merged 29 commits intojfrog:devfrom
EyalDelarea:fix_nuget_tests_workflow

Conversation

@EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Dec 30, 2024 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

It seems there is an issue with the setup-dotnet action on Ubuntu regarding the installation path and permissions.

  1. Inconsistent installation path: [Issue #554](Looks like when setup-dotnet is used, then the install path is different from the hosted images actions/setup-dotnet#554)
  2. Insufficient permissions: [Issue #565](mkdir: cannot create directory ‘/usr/share/dotnet’: Permission denied actions/setup-dotnet#565)

Until these issues are consistently resolved, this PR manually sets the installation directory and adjusts its permissions to prevent crashes during installation.

EyalDelarea and others added 23 commits December 25, 2024 22:22
@EyalDelarea
test
57211f4
@EyalDelarea
Add env for ubuntu
aec1499
@EyalDelarea
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into fix_tests
5d6db33
@EyalDelarea
Add env DOTNET_INSTALL_DIR
f363462
@EyalDelarea
trigger
8a7ec06
@EyalDelarea
test without
df6c27d
@EyalDelarea
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into fix_tests
c830492
@EyalDelarea
Test Fix nugetTests.yml
c9d897b
@EyalDelarea
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli into fix_tests
040238d
@EyalDelarea
Install .NET before NuGet
990d20f
@EyalDelarea
Remove .NET env var
e29bef7
@EyalDelarea
Add comments
f50d3de
@EyalDelarea
Update the oldest version of mac-os from 12 to 13
a3aa044
@EyalDelarea
Change the image for artifactory 6
b3f4ce2
@EyalDelarea
Add comment
d993e9e
@EyalDelarea @sverdlov93
Update pip_test.go
7411975 
Co-authored-by: Michael Sverdlov <sverdlov93@gmail.com>
@EyalDelarea
test nuget version
197a15a
@EyalDelarea
version 8
b14ef47
@EyalDelarea
version 6
4a4afff
@EyalDelarea
test
ae6b4c5
@EyalDelarea
only set env for ubuntu
1e10beb
@EyalDelarea
test
7c60109
@EyalDelarea
test2
53b0a67
@EyalDelarea EyalDelarea added the ignore for release Automatically generated release notes label Dec 30, 2024
@EyalDelarea EyalDelarea changed the base branch from v2 to dev December 30, 2024 09:25
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Dec 30, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 30, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Dec 30, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 30, 2024
@EyalDelarea EyalDelarea force-pushed the fix_nuget_tests_workflow branch from b0f4233 to 9a4fb10 Compare December 30, 2024 10:54
@EyalDelarea EyalDelarea marked this pull request as ready for review December 30, 2024 12:00
@EyalDelarea EyalDelarea merged commit dea84f2 into jfrog:dev Dec 30, 2024
13 of 14 checks passed
@EyalDelarea EyalDelarea mentioned this pull request Jan 2, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sverdlov93 sverdlov93 sverdlov93 approved these changes

Assignees

No one assigned

Labels

ignore for release Automatically generated release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EyalDelarea @sverdlov93