create detailed summary for every command when JFROG_CLI_COMMAND_SUMMARY_OUTPUT_DIR is set#2820
create detailed summary for every command when JFROG_CLI_COMMAND_SUMMARY_OUTPUT_DIR is set#2820ahippler wants to merge 3 commits intojfrog:dev-deprecated-please-target-master-directlyfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Hey @ahippler, Thank you for your contribution! To add commands to the summary, you would need to record relevant data during the command's execution and implement functions to transform this data into markdown. Unfortunately, achieving this for every command with just a one-liner change isn’t feasible. Moreover, we aim to avoid summarizing every command, as doing so would dilute the purpose of having a concise and meaningful summary. Could you elaborate on the specific use case you have in mind? I’d love to hear your thoughts! If you're looking for more information on how to implement new command summaries, feel free to check out the documentation here. Best regards, |
|
Hi. The PR is not about adding commands to the summary. Its about unifying the usage with the github action setup-jfrog-cli. The action configures the env var JFROG_CLI_COMMAND_SUMMARY_OUTPUT_DIR and some commands generate automatically a summary in the github action run. Other commands like |
|
This pull-request was closed due to 7 days of inactivity after being marked as stale. Feel free to reopen it if it remains relevant. |
devbranch.go vet ./....go fmt ./....Some commands use the
cliutils.GetDetailedSummarywhich checks JFROG_CLI_COMMAND_SUMMARY_OUTPUT_DIR but others only use thedetailed-summarycli flag. This PR unifies this and usescliutils.GetDetailedSummaryfor every command.This will be useful for the github setup-jfrog-cli action to enable the summary on every command.