Skip to content

Fix rbc command to accept project with no spec #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bhanurp merged 16 commits into from
Feb 26, 2025
Merged

Fix rbc command to accept project with no spec #2884

bhanurp merged 16 commits into from
Feb 26, 2025

Conversation

@bhanurp
Copy link
Contributor

@bhanurp bhanurp commented Feb 24, 2025 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Depends On

jfrog/jfrog-cli-core#1356

Fixes #2874

@bhanurp bhanurp added the bug Something isn't working label Feb 24, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 24, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 24, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 24, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 24, 2025
EyalDelarea
EyalDelarea suggested changes Feb 25, 2025
View reviewed changes
lifecycle/cli.go Outdated

if buildName != "" && buildNumber != "" {
return speccore.CreateSpecFromBuildNameAndNumber(buildName, buildNumber)
return speccore.CreateSpecFromBuildNameAndNumber(buildName, buildNumber, cliutils.GetProject(c))
Copy link
Contributor

@EyalDelarea EyalDelarea Feb 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Let's just add e2e tests to verify the release bundle is being created at the right project

Copy link
Contributor Author

@bhanurp bhanurp Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added new test TestCreateBundleWithoutSpecAndWithProject

@EyalDelarea EyalDelarea linked an issue Feb 25, 2025 that may be closed by this pull request
jf rbc (release-bundle-create) is not working when using Artifactory projects #2874
Closed
@bhanurp bhanurp marked this pull request as ready for review February 26, 2025 06:02
@bhanurp bhanurp changed the title Fix for #2874 release-bundle-create is not working with projects Fix rbc command to accept project with no spec Feb 26, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@bhanurp bhanurp requested a review from EyalDelarea February 26, 2025 09:49
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@bhanurp bhanurp added the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 26, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.

@bhanurp bhanurp merged commit 0286a81 into jfrog:dev Feb 26, 2025
63 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Feb 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobiNino RobiNino Awaiting requested review from RobiNino

@itsmeleela itsmeleela Awaiting requested review from itsmeleela

@EyalDelarea EyalDelarea Awaiting requested review from EyalDelarea

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

jf rbc (release-bundle-create) is not working when using Artifactory projects

2 participants

@bhanurp @EyalDelarea