Allow Build Publish with overwrite Flag When Build Number is New#2926
Merged
Allow Build Publish with overwrite Flag When Build Number is New#2926
overwrite Flag When Build Number is New#2926Conversation
bhanurp
added
the
safe to test
github-actions
bot
removed
the
safe to test
bhanurp
added
the
safe to test
github-actions
bot
removed
the
safe to test
bhanurp
added
ignore for release
github-actions
bot
removed
the
safe to test
Contributor
itsmeleela
reviewed
Apr 14, 2025
|
|
||
| // Run build-publish with overwrite flag and build should be published | ||
| runRt(t, "bp", buildName, nonExistingBuildNumber, "--overwrite=true") | ||
| publishedBuildInfo, found, err = tests.GetBuildRuns(serverDetails, buildName) |
Collaborator
There was a problem hiding this comment.
Do we have a test already that is testing same scenario but flag value is false (I mean without flag)?
I suggest to add one as we are here anyway
Contributor
Author
There was a problem hiding this comment.
by default all other tests doesn't include flag(--overwrite) which makes default (--overwrite=false)
itsmeleela
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....Depends On
jfrog/jfrog-cli-artifactory#55
Fix: Allow Build Publish with
overwriteFlag When Build Number is NewIssue
When attempting to publish a build with the
overwriteflag, the process fails if thebuildNamealready exists in Artifactory but thebuildNumberis new. The failure occurs due to a missing build number in Artifactory.Current Behavior
Solution
buildNumberis not yet available in Artifactory.This PR adds functional tests to above case.