Skip to content

Conversation

@EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Mar 31, 2025

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Summary

This PR upgrades core tooling and module dependencies to ensure compatibility, security, and feature availability. It includes:


🆙 Go Version Bump

  • Go version upgraded from 1.23.4 to 1.23.7
    • Updated in:
      • Jenkinsfile
      • go.mod
      • Dockerfile: build/docker/slim/Dockerfile
    • Ensures the CLI builds and runs with the latest available patches and improvements in Go 1.23.x.

📦 Dependency Updates

  • Direct dependencies updated:

    • github.com/ProtonMail/go-crypto: v1.1.5 → v1.1.6
    • golang.org/x/exp: e0ece0dbea4c → 054e65f0b394
    • github.com/forPelevin/gomoji: v1.2.0 → v1.3.0
    • github.com/go-git/go-git/v5: v5.13.2 → v5.14.0
  • Transitive dependencies upgraded, including:

    • golang.org/x/crypto, x/net, x/mod, x/sync, x/term, x/text, x/tools, google/go-cmp, rogpeppe/go-internal, and more.
    • These upgrades improve performance, fix bugs, and reduce vulnerability surface area.

🧪 Minor Cleanup

  • Add a // jfrog-ignore annotation in nuget_test.go for internal test metadata.

✅ Why This Matters

  • Security: Ensures all dependencies are using the latest vetted patches.
  • Stability: Avoids potential issues caused by outdated or buggy module versions.
  • Build Consistency: Keeps all environments aligned with the expected Go version.

Depends on:
jfrog/jfrog-client-go#1104
jfrog/jfrog-cli-core#1371

@EyalDelarea EyalDelarea added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Mar 31, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 31, 2025
@EyalDelarea EyalDelarea changed the title Update deps Update Go version Mar 31, 2025
@EyalDelarea EyalDelarea added improvement Automatically generated release notes and removed ignore for release Automatically generated release notes labels Mar 31, 2025
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Mar 31, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 31, 2025
@EyalDelarea EyalDelarea marked this pull request as ready for review March 31, 2025 10:23
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Apr 3, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 3, 2025
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Apr 3, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.


@EyalDelarea EyalDelarea merged commit eee4967 into jfrog:dev Apr 3, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants