Feature/docker validate sha #2971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 11, 2025
agrasth
force-pushed
the
feature/docker-validate-sha
branch
from
facc5d9 to
6dcad6b
Compare
agrasth
force-pushed
the
feature/docker-validate-sha
branch
from
6dcad6b to
107f393
Compare
agrasth
force-pushed
the
feature/docker-validate-sha
branch
from
c8fc46d to
eeaa95c
Compare
agrasth
force-pushed
the
feature/docker-validate-sha
branch
from
eeaa95c to
f580e09
Compare
agrasth
force-pushed
the
feature/docker-validate-sha
branch
from
f580e09 to
de14255
Compare
agrasth
force-pushed
the
feature/docker-validate-sha
branch
from
de14255 to
1409f88
Compare
bhanurp
requested changes
May 22, 2025
docs/buildtools/dockerpush/help.go
Outdated
| The docker push args to run docker push.` | ||
| The docker push args to run docker push. | ||
| --validate-sha |
Contributor
There was a problem hiding this comment.
since it is a flag, do we need to update here?
Contributor
Author
There was a problem hiding this comment.
Yeah, you are right, for flags we don't need to update here.
| Usage: "[Default: false] Set to true if you'd like to use the native client configurations. Note: This flag would invoke native client behind the scenes, has performance implications and does not support deployment view and detailed summary` `", | ||
|
|
||
| }, | ||
| validateSha: cli.BoolFlag{ |
Contributor
There was a problem hiding this comment.
what ist he difference between container push command and docker, dockerPush is it like OCI support?
Contributor
Author
There was a problem hiding this comment.
What I understood was
- DockerPush Specifically for Docker images, using the Docker CLI under the hood
- ContainerPush - A more generic command that supports multiple container technologies, not just Docker.
Since both commands perform pushing operations that could benefit from SHA validation, it makes sense to add the flag to both.
Contributor
Author
There was a problem hiding this comment.
What I understood was
- DockerPush Specifically for Docker images, using the Docker CLI under the hood
- ContainerPush - A more generic command that supports multiple container technologies, not just Docker.
Since both commands perform pushing operations that could benefit from SHA validation, it makes sense to add the flag to both.
| ContainerPush: { | ||
| BuildName, BuildNumber, module, url, user, password, accessToken, sshPassphrase, sshKeyPath, | ||
| serverId, skipLogin, threads, Project, detailedSummary, | ||
| serverId, skipLogin, threads, Project, detailedSummary, validateSha, |
Contributor
There was a problem hiding this comment.
is the flag required here as well as in jfrog-cli-artifactory?
agrasth
force-pushed
the
feature/docker-validate-sha
branch
from
56eb6ae to
f8364d2
Compare
agrasth
force-pushed
the
feature/docker-validate-sha
branch
from
a73b7f1 to
2ec4dda
Compare
agrasth
added
the
safe to test
agrasth
force-pushed
the
feature/docker-validate-sha
branch
from
2ec4dda to
542ac45
Compare
agrasth
added
safe to test
github-actions
bot
removed
the
safe to test
agrasth
force-pushed
the
feature/docker-validate-sha
branch
from
542ac45 to
559cdc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....Add
--validate-shaflag for Docker push commandDescription
This PR adds a new
--validate-shaflag to the Docker push command. When enabled, the flag allows the CLI to use the image's SHA digest for validation instead of the tag name during Docker push operations. This is particularly useful when pushing to virtual repositories where the tag might exist with different content in higher priority repositories.Changes
Testing
jf rt docker-push) and new (jf docker push) CLI syntaxRelated PRs